Include a name in the #endif for all include guards

ASSIGNED
Assigned to

Status

()

Core
JavaScript Engine
ASSIGNED
3 years ago
2 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Depends on: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8711181 [details] [diff] [review]
fix_endif_missing_name-v0.diff

And regularize spacing, etc. This patch was edited together manually with the list was generated by:

'''bash
#!/bin/bash
FILES=`find . -name "*.h" | grep -v irreg | grep -v libffi | grep -v vixl | grep -v editline | grep -v vtune | grep -v style | grep -v llvm-compiler-rt | grep -v js-conf`

for FILE in $FILES; do
    GUARDNAME=`sed -n "s/#ifndef \(.*_h\)$/\1/p" ${FILE}`
    if [ -z $GUARDNAME ]; then
        echo "Missing guard in: "$FILE
        exit 1
    fi

    grep -q "#endif....${GUARDNAME}" ${FILE} || echo "Missing end name in ${FILE}"
done

'''
(Assignee)

Updated

3 years ago
Blocks: 1242060
(Assignee)

Updated

3 years ago
Component: JavaScript: GC → JavaScript Engine
Do we want to switch the existing /* */ end names to use // while we're at it? While we're nitpicking :)
You need to log in before you can comment on or make changes to this bug.