Closed Bug 1242137 Opened 4 years ago Closed 4 years ago

Fix eslint errors in /browser/components/customizableui

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch WIP patch (obsolete) — Splinter Review
No description provided.
4173 INFO Browser Chrome Test Summary
4174 INFO Passed:  2622
4175 INFO Failed:  0
4176 INFO Todo:    0
Can you remove the browser/components/tabview/** entry from .eslintignore while you're at it?
Comment on attachment 8711357 [details]
MozReview Request: Bug 1242137 - Fix eslint errors in /browser/components/customizableui. r?gijs

https://reviewboard.mozilla.org/r/32125/#review28837

::: browser/components/customizableui/CustomizableUI.jsm:263
(Diff revision 1)
> -        // This is duplicated logic from /browser/base/jar.mn
> +              // This is duplicated logic from /browser/base/jar.mn
> -        // for win6BrowserOverlay.xul.
> +              // for win6BrowserOverlay.xul.
> -        return Services.appinfo.OS == "WINNT" &&
> +              return Services.appinfo.OS == "WINNT" &&
> -               Services.sysinfo.getProperty("version") != "5.1";
> +                     Services.sysinfo.getProperty("version") != "5.1";

Nit: return AppConstants.isPlatformAndVersionAtLeast("win", 6);

::: browser/components/customizableui/moz.build
(Diff revision 1)
> -if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('windows', 'cocoa'):
> -    DEFINES['CAN_DRAW_IN_TITLEBAR'] = 1

You need to leave this in because of:

https://dxr.mozilla.org/mozilla-central/rev/d6d81655dd9e146c300a64c0fcaeb04ca3300a19/browser/components/customizableui/content/customizeMode.inc.xul#22

I am surprised there are no test failures because of this, apparently we don't test that that button works. :-(

::: browser/components/customizableui/moz.build:22
(Diff revision 1)
>  EXTRA_PP_JS_MODULES += [

Nit: just remove the collection which is now empty. :-)
Attachment #8711357 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #5)
> ::: browser/components/customizableui/moz.build
> (Diff revision 1)
> > -if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('windows', 'cocoa'):
> > -    DEFINES['CAN_DRAW_IN_TITLEBAR'] = 1
> 
> You need to leave this in because of:
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> d6d81655dd9e146c300a64c0fcaeb04ca3300a19/browser/components/customizableui/
> content/customizeMode.inc.xul#22
> 
> I am surprised there are no test failures because of this, apparently we
> don't test that that button works. :-(

Hm, or maybe I'm wrong because that file actually gets included in browser/base, where it is defined separately? :-\
https://hg.mozilla.org/mozilla-central/rev/9fe442edbbe1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.