Closed Bug 1242140 Opened 4 years ago Closed 4 years ago

Remote debugging not working: stays in Connecting state

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(thunderbird45 unaffected, thunderbird46 fixed, thunderbird47 fixed)

RESOLVED FIXED
Thunderbird 47.0
Tracking Status
thunderbird45 --- unaffected
thunderbird46 --- fixed
thunderbird47 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

Details

(Keywords: regression)

Attachments

(1 file)

Latest Daily. This is a regression from bug 1237602.
Comment on attachment 8711320 [details] [diff] [review]
patch, v1

Review of attachment 8711320 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review to get the debugger working again, r=philipp
Attachment #8711320 - Flags: review?(acelists) → review+
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
Fwiw, this wasn't broken by bug 1237602, there is no list comprehension here, just an incorrect Map.forEach callback.
Comment on attachment 8711320 [details] [diff] [review]
patch, v1

[Approval Request Comment]
Regression caused by (bug #): bug  1237602 
User impact if declined: Remote debugging not working
Testing completed (on c-c, etc.): Verified fix on c-c
Risk to taking this patch (and alternatives if risky): low (reverts to previous behavior)
Attachment #8711320 - Flags: approval-comm-aurora?
Attachment #8711320 - Flags: approval-comm-aurora? → approval-comm-aurora+
Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/d5a354015782
(DONTBUILD, next Daily will puck it up).
s/puck/pick/
You need to log in before you can comment on or make changes to this bug.