Remove implementation of colspan=0 (which is now dead code)

RESOLVED FIXED in Firefox 47

Status

()

--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1241840 will map table cell colspan=0 to 1.  This means we can remove
all the code that implements colspan=0 since it's now dead code.
(Assignee)

Updated

3 years ago
Assignee: nobody → mats
(Assignee)

Comment 1

3 years ago
Created attachment 8711721 [details] [diff] [review]
fix
Attachment #8711721 - Flags: review?(dbaron)
Comment on attachment 8711721 [details] [diff] [review]
fix

From struct nsTableFrame::TableBits, please remove mHasZeroColSpans *and* mNeedColSpanExpansion, and remove everything that depends on those (transitively).  (I think it should be mostly uninteresting -- but if it is interesting, please request re-review.)

Please file a followup bug on the XXX in nsTableEditor, and add a bug number to the XXX.

Please remove the function nsCellMap::GetColSpanForNewCell and just call GetColSpan on the cell directly at its two callers.

r=dbaron with that
Attachment #8711721 - Flags: review?(dbaron) → review+
(Assignee)

Updated

3 years ago
Blocks: 1243183
(Assignee)

Comment 5

3 years ago
(In reply to David Baron [:dbaron] ⌚️UTC+13 from comment #3)

Thanks, I fixed those too (trivial changes), and filed follow-up Editor bug 1243183.

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d731a5fbdd9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.