1242188 - Sidebar Panel Name heading text of narrow sidebar exceeds right border of sidebar

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Rainer Bielefeld]

Attachment: screenshot with comments

Steps how to reproduce  NOT reproducible  REPRODUCIBLE with  SeaMonkey German 2.39 final Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0 from official download area)  Gecko/20100101  Firefox/42.0  Build 20151103191810  (Classic Theme) on German WIN7 64bit:

1. Launch SeaMonkey browser
2. if necessary <f9> to show sidebar
3. Drag and drop right sidebar border to the left to decrease sidebar width
   Bug: heading text layer is in front of right sidebar border, but 
       should be behind.

Comment 1

[Rainer Bielefeld]

Already REPRODUCIBLE with  DE  SeaMonkey 2.0  (Windows NT 6.1; WOW64; rv:1.9.1.4)  Gecko/20091017  Build 20091017081335  (Default Classic Theme) on German WIN7 64bit.

Also REPRODUCIBLE with  English SeaMonkey 2.43a1  (X11; Linux x86_64; rv:46.0)  Gecko/20100101 Firefox/46.0 Build 20160109003001  (Default Default Theme) on VirtualBox Ubuntu 14.04 LTS

Does not depend on Theme, same problem with "Modern" theme.

Comment 2

[Tony Mechelynck [:tonymec]]

I can reproduce this on:
UA:"Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0 SeaMonkey/2.43a1"
ID:20160109003001 en-US
c-c:4f4f6a3674c9e16efacf62fd8963c8be5a31b07c
m-c:0f363ae95dc90d593394ef464aa500804c824962

I believe that this is a consequence of how the sidebar is built:
It is possible to continuously drag the sidebar right border, giving the sidebar any width between zero (at which point the ◀ arrows on its grippy will reverse direction and become ▶, showing the sidebar is still present but collapsed) to some rather wide maximum (approximately one-third of the maximized SeaMonkey window on my 1280x1024 display). When continuously reducing the sidebar width by dragging its border, at some point the width will necessarily become less than the length of more and more of the labels on the tabs and buttons, which will then have to be clipped.

The alternative, IIUC, would be to have the sidebar slap shut as soon as the user tries to make it narrower than the longest label on any button or tab (and how long is the longest may vary depending on the UI locale). This would IMHO be much less user-friendly than the present behaviour.

I suggest WONTFIX.

Comment 3

[Philip Chee]

sidebar.css (both classic and modern)

> /* ::::: sidebar header ::::: */

> .sidebarheader-main {
>   -moz-appearance: toolbar;
>   border: 1px outset InactiveCaption;
>   background-color: InactiveCaption;
>   color: CaptionText;
>   padding-top: 1px;
>   padding-bottom: 1px;
>   -moz-padding-start: 6px;
>   -moz-padding-end: 2px;
>   height: auto;
> }

Add:
  overflow-x: hidden;

Comment 4

[Tony Mechelynck [:tonymec]]

Attachment: add "overflow-hidden" to sidebar header rules

Comment 5

[Philip Chee]

Comment on attachment 8714198 [details] [diff] [review]
add "overflow-hidden" to sidebar header rules

Good! r=me

> add "overflow-hidden" to sidebar header rules
Please add the bug number to the commit message. Thanks.

Comment 6

[Tony Mechelynck [:tonymec]]

Attachment: Bug 1242188: add "overflow-hidden" to sidebar header rules r=Ratty a=Ratty for all branches

Commit message (in patch metadata) updated according to comment #5.
No change to the patch code itself.
Carrying forward r+=Ratty

Comment 7

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/4902a25378de

Comment 8

[Tony Mechelynck [:tonymec]]

Comment on attachment 8716686 [details] [diff] [review]
Bug 1242188: add "overflow-hidden" to sidebar header rules r=Ratty a=Ratty for all branches

Patch applies cleanly to aurora; I don't have a beta clone.

[Approval Request Comment]
Regression caused by (bug #): unknown, SeaMonkey 2.0 or earlier
User impact if declined: ugly overflow of sidebar titles into content area when sidebar is too narrow for them
Testing completed (on m-c, etc.): Patch landed on m-c, see comment #7
Risk to taking this patch (and alternatives if risky): very low or none (purely cosmetic changes)
String changes made by this patch: none

Comment 9

[Tony Mechelynck [:tonymec]]

Comment on attachment 8716686 [details] [diff] [review]
Bug 1242188: add "overflow-hidden" to sidebar header rules r=Ratty a=Ratty for all branches

[Approval Request Comment] answers see above, comment 8

Approve only if this can be applied in time for the 2.40 release: this is very-low-risk but non-security non-stability

Comment 10

[Tony Mechelynck [:tonymec]]

oops, isn't the "comm-release" repo at 2.41 already?

Comment 11

[Tony Mechelynck [:tonymec]]

(In reply to Philip Chee from comment #3)
> sidebar.css (both classic and modern)
> 
> > /* ::::: sidebar header ::::: */
> 
> > .sidebarheader-main {
> >   -moz-appearance: toolbar;
> >   border: 1px outset InactiveCaption;
> >   background-color: InactiveCaption;
> >   color: CaptionText;
> >   padding-top: 1px;
> >   padding-bottom: 1px;
> >   -moz-padding-start: 6px;
> >   -moz-padding-end: 2px;
> >   height: auto;
> > }
> 
> Add:
>   overflow-x: hidden;

Didn't notice there was a third theme, "Classic for the Mac". The corresponding rule (in suite/themes/classic/mac/communicator/sidebar/sidebar.css) has a slightly different (but similar) set of rules (lines 21-32):

21 /* ::::: sidebar header ::::: */
22 
23 .sidebarheader-main {
24   -moz-appearance: toolbar;
25   background-color: InactiveCaption;
26   color: CaptionText;
27   padding-top: 1px;
28   padding-bottom: 1px;
29   -moz-padding-start: 6px;
30   -moz-padding-end: 2px;
31 }
32 

- Shouldn't the same "overflow-x:hidden" line be added? (I think it should)
- Are the rules for border and height intentionally missing?

Rainer is (AFAICT) on Windows and I'm on Linux so I can't be sure that this bug also happens on the Mac.

Comment 12

[Philip Chee]

> - Shouldn't the same "overflow-x:hidden" line be added? (I think it should)
I think it doesn't hurt
> - Are the rules for border and height intentionally missing?
Probably OSX doesn't need them. Let's ask Stefanh

Comment 13

[Philip Chee]

Comment on attachment 8716686 [details] [diff] [review]
Bug 1242188: add "overflow-hidden" to sidebar header rules r=Ratty a=Ratty for all branches

low risk bug fix.

Comment 14

[Stefan [:stefanh]]

(In reply to Tony Mechelynck [:tonymec] from comment #11)

> - Shouldn't the same "overflow-x:hidden" line be added? (I think it should)
Yes, they should. The same issue exists on Mac.

> - Are the rules for border and height intentionally missing?
For the border rule: Yes, see bug 599621, comment #2. The height rule was added by Neil in http://hg.mozilla.org/comm-central/rev/702c3b2337ab, so the answer is also yes.

Comment 15

[Tony Mechelynck [:tonymec]]

Attachment: Bug 1242188 part 2: additional patch for the Mac

Approval Request Comment: answers see comment #8 and 9; see also a+ on comment #13

This is the same patch as the other one but for the 3rd theme (Classic for the Mac).

Comment 16

[Tony Mechelynck [:tonymec]]

this is still a GFB but IMHO making the whole [checkin: ] whiteboard entry visible is more important.

Comment 17

[Tony Mechelynck [:tonymec]]

Comment on attachment 8717790 [details] [diff] [review]
Bug 1242188 part 2: additional patch for the Mac

oops, approval requested for wrong repo

Comment 18

[Philip Chee]

Comment on attachment 8717790 [details] [diff] [review]
Bug 1242188 part 2: additional patch for the Mac

a=me for all branches

Comment 19

[Tony Mechelynck [:tonymec]]

Thanks Ratty!
http://hg.mozilla.org/comm-central/rev/81b5240cbf3b
http://hg.mozilla.org/releases/comm-aurora/rev/af8ebebafffb
http://hg.mozilla.org/releases/comm-aurora/rev/d5b323d6bd43
http://hg.mozilla.org/releases/comm-beta/rev/200e720ca7ae
http://hg.mozilla.org/releases/comm-beta/rev/e9d4350c31ab
http://hg.mozilla.org/releases/comm-release/rev/21e67a0fbd7b
http://hg.mozilla.org/releases/comm-release/rev/d03261503692

Comment 20

[Tony Mechelynck [:tonymec]]

Comment on attachment 8716686 [details] [diff] [review]
Bug 1242188: add "overflow-hidden" to sidebar header rules r=Ratty a=Ratty for all branches

Ratty: apparently you forgot to set a+r here when you landed it; I can set a? but not a+