Closed Bug 1242214 Opened 4 years ago Closed 4 years ago

Rename JSPropertyDescriptor to JS::PropertyDescriptor

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

Details

Attachments

(2 files)

No description provided.
Attachment #8711453 - Flags: review?(bugs) → review+
Attachment #8711452 - Flags: review?(jorendorff) → review?(sstangl)
Comment on attachment 8711452 [details] [diff] [review]
Rename JSPropertyDescriptor JS::PropertyDescriptor in js/

Review of attachment 8711452 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jspubtd.h
@@ +137,5 @@
>  
>  namespace JS {
>  
> +// Maybe?
> +struct PropertyDescriptor;

Shouldn't this be declared in some header? At worst, probably remove the comment.
Attachment #8711452 - Flags: review?(sstangl) → review+
https://hg.mozilla.org/mozilla-central/rev/27fc4690ec4d
https://hg.mozilla.org/mozilla-central/rev/114ec4ff6d65
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.