1242228 - Upgrade virtualenv to 14.0.1

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

We currently have virtualenv 12.0.5 vendored in mozilla-central. virtualenv 14.0.1 is the latest available. It contains a number of improvements, most of them coming from the latest versions of setuptools and pip. Let's upgrade.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1242228 - Upgrade virtualenv to 14.0.1; r?mshal

Downloaded from https://pypi.python.org/packages/source/v/virtualenv/virtualenv-14.0.1.tar.gz
and extracted without any modifications.

This appears to speed up `mach configure` for artifact builds by ~3.3s on
my Linux machine (~16.3s to 13.0s). A significant part of this appears
to be newer version of pip caching and reusing wheels after first
install.

This should be a rubber stamp review, as all changes are from trusted
upstream packages.

Review commit: https://reviewboard.mozilla.org/r/32153/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32153/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8711394 [details]
MozReview Request: Bug 1242228 - Upgrade virtualenv to 14.0.1; r?mshal

https://reviewboard.mozilla.org/r/32153/#review28963

Stamp!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de1139d08196

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de1139d08196

Comment 5

[aleth [:aleth]]

Could this be related to the following c-c build regression?

 Processing /builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/testing/mozbase/mozrunner
 Collecting blessings>=1.3 (from mozlog==3.1)
   The repository located at pypi.pvt.build.mozilla.org is not a trusted or secure host and is being ignored. If this repository is available via HTTPS it is recommended to use HTTPS instead, otherwise you may silence this warning and allow it anyways with '--trusted-host pypi.pvt.build.mozilla.org'.
   The repository located at pypi.pub.build.mozilla.org is not a trusted or secure host and is being ignored. If this repository is available via HTTPS it is recommended to use HTTPS instead, otherwise you may silence this warning and allow it anyways with '--trusted-host pypi.pub.build.mozilla.org'.
   Could not find a version that satisfies the requirement blessings>=1.3 (from mozlog==3.1) (from versions: )
 No matching distribution found for blessings>=1.3 (from mozlog==3.1)
 Python: 2.7.3 (default, Jul 11 2013, 11:07:49) 
 [GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)]
 Failure to install packages
 make[6]: *** [mozmill-virtualenv] Error 1
 make[5]: *** [mail/test/mozmill/libs] Error 2

A few hours ago, this read

Processing /builds/slave/tb-c-cen-m64-00000000000000000/build/mozilla/testing/mozbase/mozrunner
Collecting blessings>=1.3 (from mozlog==3.1)
  This repository located at pypi.pvt.build.mozilla.org is not a trusted host, if this repository is available via HTTPS it is recommend to use HTTPS instead, otherwise you may silence this warning with '--trusted-host pypi.pvt.build.mozilla.org'.
  DEPRECATION: Implicitly allowing locations which are not hosted at a secure origin is deprecated and will require the use of --trusted-host in the future.
  This repository located at pypi.pub.build.mozilla.org is not a trusted host, if this repository is available via HTTPS it is recommend to use HTTPS instead, otherwise you may silence this warning with '--trusted-host pypi.pub.build.mozilla.org'.
  Downloading http://pypi.pvt.build.mozilla.org/pub/blessings-1.6.tar.gz
Installing collected packages: mozrunner, mozdevice, mozprocess, moznetwork, mozcrash, mozprofile, mozlog, blessings, mozinfo, mozfile, manifestparser
  Running setup.py install for mozrunner
    Installing mozrunner script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
  Running setup.py install for mozdevice
    Installing sutini script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
    Installing dm script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
  Running setup.py install for mozprocess
  Running setup.py install for moznetwork
    Installing moznetwork script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
  Running setup.py install for mozcrash
  Running setup.py install for mozprofile
    Installing mozprofile script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
    Installing diff-profiles script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
    Installing view-profile script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
  Running setup.py install for mozlog
    Installing structlog script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
  Running setup.py install for blessings
  Running setup.py install for mozinfo
    Installing mozinfo script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
  Running setup.py install for mozfile
  Running setup.py install for manifestparser
    Installing manifestparser script to /builds/slave/tb-c-cen-m64-00000000000000000/build/objdir-tb/x86_64/_tests/mozmill-virtualenv/bin
Successfully installed blessings-1.6 manifestparser-1.1 mozcrash-0.16 mozdevice-0.48 mozfile-1.2 mozinfo-0.9 mozlog-3.1 moznetwork-0.27 mozprocess-0.22 mozprofile-0.28 mozrunner-6.11

Comment 6

[Gregory Szorc [:gps]]

Almost certainly. Newer versions of Python packaging tools are much more strict about security. You'll need to change your test automation to trust the host. Preferably, you'd use TLS everywhere so you don't need this workaround.