[TV][Settings] Implement key navigation feature for supporting TV form-factor.

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: seanlee, Assigned: seanlee)

Tracking

(Blocks: 1 bug)

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.6?)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In this bug, we will have a basic TV settings app for TV form-factor to configure WiFi with key navigation support.
(Assignee)

Updated

2 years ago
Summary: [TV][Settings] Implement Settings infrastructure for supporting TV form-factor. → [TV][Settings] Implement key navigation feature for supporting TV form-factor.
(Assignee)

Updated

2 years ago
Depends on: 1245426
Created attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
In attachment 8715224 [details] [review], settings app can be used in TV Build with key navigation support.
There are still these components have to support key navigation:
1. dialog pattern in settings app.
2. value selector in system app.
3. gaia-switch, gaia-radio and gaia-checkbox (bug 1245426)
(Assignee)

Updated

2 years ago
Assignee: nobody → selee
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

Hey Fred,

Could you help to review this patch? Thank you!
Attachment #8715224 - Flags: review?(gasolin)

Comment 4

2 years ago
Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

Thanks for the patch!
The overall looks good, please address issues on Github and set review again.
Attachment #8715224 - Flags: review?(gasolin)
(Assignee)

Comment 5

2 years ago
Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

Hey Fred,

One more round! Thanks! :)
Attachment #8715224 - Flags: review?(gasolin)
(Assignee)

Updated

2 years ago
Blocks: 1254815

Comment 6

2 years ago
Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

looks good, 1 nit on github.

Please merge after test success on device and treeherder
Attachment #8715224 - Flags: review?(gasolin) → review+
(Assignee)

Updated

2 years ago
Blocks: 1255264
(Assignee)

Updated

2 years ago
blocking-b2g: --- → 2.6?
(Assignee)

Updated

2 years ago
Blocks: 1257282
You need to log in before you can comment on or make changes to this bug.