1242314 - [TV][Settings] Implement key navigation feature for supporting TV form-factor.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P2)

Description

[Sean Lee [:seanlee][:weilonge]]

In this bug, we will have a basic TV settings app for TV form-factor to configure WiFi with key navigation support.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

Comment 2

[Sean Lee [:seanlee][:weilonge]]

In attachment 8715224 [details] [review], settings app can be used in TV Build with key navigation support.
There are still these components have to support key navigation:
1. dialog pattern in settings app.
2. value selector in system app.
3. gaia-switch, gaia-radio and gaia-checkbox (bug 1245426)

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

Hey Fred,

Could you help to review this patch? Thank you!

Comment 4

[[e-mail]]

Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

Thanks for the patch!
The overall looks good, please address issues on Github and set review again.

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

Hey Fred,

One more round! Thanks! :)

Comment 6

[[e-mail]]

Comment on attachment 8715224 [details] [review]
[gaia] weilonge:seanlee/TVSettings/master/Bug1242314 > mozilla-b2g:master

looks good, 1 nit on github.

Please merge after test success on device and treeherder

Comment 7

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/eeedf205f728573c570c3b86f71d51916288bd04
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=793a6ef2a49224aa56d658ce9b4d505847e3de0f