Closed Bug 1242321 Opened 4 years ago Closed 3 years ago

Remove obsolete "media.eme.apiVisible" pref

Categories

(Core :: Audio/Video: Playback, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox46 --- affected
firefox53 --- wontfix
firefox54 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

The "media.eme.apiVisible" pref is no longer necessary. The EME APIs are always visible, even when EME support is disabled in the EME opt-out builds or when the user unchecks the "Play DRM content" setting.
Attachment #8711537 - Flags: review?(cpearce)
Comment on attachment 8711537 [details] [diff] [review]
remove-media-eme-apiVisible-pref.patch

Review of attachment 8711537 [details] [diff] [review]:
-----------------------------------------------------------------

Because you changed a WebIDL file, you'll also need a DOM peer r+ to get past the landing hooks.
Attachment #8711537 - Flags: review?(cpearce) → review+
Comment on attachment 8711537 [details] [diff] [review]
remove-media-eme-apiVisible-pref.patch

This patch removes the [Pref="media.eme.apiVisible"] WebIDL annotation because the "media.eme.apiVisible" pref is never false. The EME APIs are always visible, even when EME support is disabled in the EME opt-out builds or when the user unchecks the "Play DRM content" setting.

Boris, you reviewed the original patch (in bug 1131755) to add the [Pref="media.eme.apiVisible"] WebIDL annotation.
Attachment #8711537 - Flags: superreview?(bzbarsky)
P5
Priority: -- → P5
Comment on attachment 8711537 [details] [diff] [review]
remove-media-eme-apiVisible-pref.patch

sr=me.  Thank you for that drive-by spelling fix!
Attachment #8711537 - Flags: superreview?(bzbarsky) → superreview+
You have this failure - dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface MediaEncryptedEvent to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=20466540&repo=mozilla-inbound
Flags: needinfo?(cpeterson)
This also caused M(5) failures:
01:50:02     INFO -  545 INFO TEST-START | layout/generic/test/test_plugin_focus.html
01:55:32     INFO -  546 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Got plugin painted event from p2
01:55:32     INFO -  547 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Got plugin painted event from p1
01:55:32     INFO -  548 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Check event type
01:55:32     INFO -  549 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Check event target
01:55:32     INFO -  550 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Check event type
01:55:32     INFO -  551 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Check event target
01:55:32     INFO -  552 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Check event type
01:55:32     INFO -  553 INFO TEST-PASS | layout/generic/test/test_plugin_focus.html | Check event target
01:55:32  WARNING -  TEST-UNEXPECTED-TIMEOUT | layout/generic/test/test_plugin_focus.html | application timed out after 330 seconds with no output
Thanks. I will look into these test failures.
Flags: needinfo?(cpeterson)
Now that bug 1332981 has enabled EME support on Android, I can land this patch to remove the "media.eme.apiVisible" pref without breaking the Android tests.
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b3d3af06aeb
Remove obsolete "media.eme.apiVisible" pref. r=cpearce sr=bz
https://hg.mozilla.org/mozilla-central/rev/0b3d3af06aeb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.