Closed
Bug 1242326
Opened 9 years ago
Closed 9 years ago
Running keyboard build.js on node.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
Attachments
(2 files)
apps/email/build/build.js contains certain XPConnect APIs that should be converted to Node.js compatible version.
Separate it from bug 1240740 since this should be verified carefully.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8711733 [details] [review]
[gaia] rickychien:keyboard-build-to-node > mozilla-b2g:master
"A gift everyday keeps the doctor away"
Attachment #8711733 -
Flags: review?(scwwu)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8711733 [details] [review]
[gaia] rickychien:keyboard-build-to-node > mozilla-b2g:master
Looks good. Thanks!
r+
Attachment #8711733 -
Flags: review?(scwwu) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Landed in master:
https://github.com/mozilla-b2g/gaia/commit/fc02aeb4ecf819f0ba67f784ee9f2923755e1edf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•