Closed
Bug 1242360
Opened 9 years ago
Closed 9 years ago
View jumps to the top of the page when clearing text from "Find in Page"
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fxios | 2.0+ | --- |
People
(Reporter: TeoVermesan, Assigned: bnicholson)
Details
Attachments
(1 file)
Tested using:
Version: 2.0(2)
Steps to reproduce:
1. Go to https://en.wikipedia.org/wiki/Mozilla
2. Scroll to the bottom of the page
3. Tap the Share button in the bottom navigation toolbar
4. Tap 'Find in Page'
5. Enter "moz"
6. Tap the down arrow, to go the last reference
7. Clear the text field
Expected results:
- View position is preserved.
Actual results:
- The view jumps to the top of the page, regardless of where the page was positioned before.
Note:
- the view position is preserved on Safari, after clearing the text
Updated•9 years ago
|
tracking-fxios:
--- → ?
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Instead of resetting to the top of the page when the query changes, we can try to resume from the last match position.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Flags: needinfo?(bnicholson)
Attachment #8717164 -
Flags: review?(sleroux)
Comment 2•9 years ago
|
||
Comment on attachment 8717164 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1510
Looks good and works pretty well! I found another bug while testing but filed it elsewhere since it wasn't related to this patch https://bugzilla.mozilla.org/show_bug.cgi?id=1247022.
Attachment #8717164 -
Flags: review?(sleroux) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 4•8 years ago
|
||
Verified as fixed on iPhone 6,iOS 10.2,Firefox version 6.0(2)
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•