1242363 - [TV][Seamless experience] No banner: "Opening a webpage received from another device." (TV Side) after sending Tab

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: Spec

STR: 
 1. Sent Tab to TV
 2. Check the screen in TV side

Expect result:
 - There should be a banner: "Opening {{website title}} from {{device name}}."
 - Please the attachment, page 13

Actual Result:
 - No banner

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Oops.
Not sure if we are able to check-in this into v2.5.

1.If we need a message, l10n key is required.
2.If we need title and device name, protocol need to be changed.
That means we need to change Fennec too.

Achieving "just 1" (Means there's a message but without title and device name)
seems to be easier if partner accepts a l10n request.

Comment 2

[Evelyn Hung]

Rex, instead of just clear your ni, please hand over to others. Otherwise this bug is out of people's attention and won't move on.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Hi Tori:
Per our current design, we can only offer the URL at the stage of showing message. So for the message, I'm thinking if we can just show a message without Title and device name... What do you think?

Comment 4

[Tori Chen [:tori]]

Hi Rex, please modify this message to "Opening a webpage received from another device."
Partner will use this message one for l10n. Thanks!

Comment 5

[Evelyn Hung]

Assign to Rex per comment 4.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1242363-popup-webpage > mozilla-b2g:master

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8713535 [details] [review]
[gaia] rexboy7:1242363-popup-webpage > mozilla-b2g:master

Hi Luke:
This is a simple patch to show a message when receiving send to TV request.
May you help review it?
Thank you!

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master:
https://github.com/mozilla-b2g/gaia/commit/e0438f6c6a49e83d0f0674678f5ddeb9e40372fd

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8713535 [details] [review]
[gaia] rexboy7:1242363-popup-webpage > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): missed behavior
[User impact] if declined: no popup message when sending tabs to TV
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky):small
[String changes made]: 1 key

Comment 10

[Josh Cheng [:josh]]

Comment on attachment 8713535 [details] [review]
[gaia] rexboy7:1242363-popup-webpage > mozilla-b2g:master

Approve for TV 2.5

Comment 11

[Carsten Book [:Tomcat]]

has problems to apply:

Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick b0a43cb2ce7603ff358cefd65628d9e1aa35892d
error: could not apply b0a43cb... Bug 1242363 - [TV][2.5] Popup a prompt message when receiving a Send-to-TV request.
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

could you take a look and provide a 2.5 PR request ?

Comment 12

[Cynthia Tang [:cynthiatang]]

Verify on master

Build ID               20160201030209
Gaia Revision          10df3a68103c4ae7bd033eb0a742deb59c01b3bf
Gaia Date              2016-02-02 19:13:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/941033a51983ddec2d99aa9f868a54c0196a4075
Gecko Version          46.0a1
Device Name            hammerhead
Firmware(Release)      5.1.1
Firmware(Incremental)  eng.cltbld.20160201.063447
Firmware Date          Mon Feb  1 06:35:05 EST 2016
Bootloader             HHZ12f

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1242363-v2.5 > mozilla-b2g:v2.5

Comment 14

[KM Lee [:rexboy] (inactivate after Sep. 22)]

v2.5 > https://github.com/mozilla-b2g/gaia/commit/cb4efe4e01290a9a36e340da34568fcf64be7b90

Comment 15

[[e-mail]]

This issue is not observed on v2.5

Build ID               20151029030207
Gaia Revision          cb4efe4e01290a9a36e340da34568fcf64be7b90
Gaia Date              2016-03-05 02:07:29
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e700005a0ddf2b17803213e1f3f8d78a7a618b8
Gecko Version          44.0a1
Device Name            hammerhead
Firmware(Release)      5.1.1
Firmware(Incremental)  eng.worker.20160204.113511
Firmware Date          Thu Feb  4 11:35:29 UTC 2016
Bootloader             HHZ12k