Closed
Bug 1242443
Opened 8 years ago
Closed 8 years ago
Add test cases for Permissions class with non-activity context and doNotPrompt()
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(1 file)
I extended the functionality of the Permissions class recently but I did not cover those changes with unit tests. Let's add them.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32281/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32281/
Attachment #8711643 -
Flags: review?(nalexander)
Comment 2•8 years ago
|
||
Comment on attachment 8711643 [details] MozReview Request: Bug 1242443 - TestPermissions: Add test cases for non-Activity context, doNotPrompt() and doNotPromptIf(). r?nalexander https://reviewboard.mozilla.org/r/32281/#review28977 Nice! I learn a little something every time you land a test patch :) BTW, I have a single failure in |mach gradle test|, in https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/background/junit4/src/org/mozilla/gecko/dlc/catalog/TestDownloadContentCatalog.java#60. Do you see that locally? (Also, that should be bootstrapper -- with two 'p' characters.) ::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/permissions/TestPermissions.java:209 (Diff revision 1) > + Permissions.onRequestPermissionsResult(activity, new String[0], new int[0]); Ah, this confused me for a second, but I see it now. Rock on.
Attachment #8711643 -
Flags: review?(nalexander) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #2) > BTW, I have a single failure in |mach gradle test|, in > https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/ > background/junit4/src/org/mozilla/gecko/dlc/catalog/ > TestDownloadContentCatalog.java#60. Do you see that locally? (Also, that > should be bootstrapper -- with two 'p' characters.) Oh! I do not see that locally because this test only passes if you have fonts excluded (MOZ_ANDROID_EXCLUDE_FONTS). I'll fix that in a follow-up.
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/63e8b3fd18f550ab35a4ac26c2169521a52365d5 Bug 1242443 - TestPermissions: Add test cases for non-Activity context, doNotPrompt() and doNotPromptIf(). r=nalexander
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/63e8b3fd18f5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•