1242443 - Add test cases for Permissions class with non-activity context and doNotPrompt()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

I extended the functionality of the Permissions class recently but I did not cover those changes with unit tests. Let's add them.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1242443 - TestPermissions: Add test cases for non-Activity context, doNotPrompt() and doNotPromptIf(). r?nalexander

Review commit: https://reviewboard.mozilla.org/r/32281/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32281/

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Comment on attachment 8711643 [details]
MozReview Request: Bug 1242443 - TestPermissions: Add test cases for non-Activity context, doNotPrompt() and doNotPromptIf(). r?nalexander

https://reviewboard.mozilla.org/r/32281/#review28977

Nice!  I learn a little something every time you land a test patch :)

BTW, I have a single failure in |mach gradle test|, in https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/background/junit4/src/org/mozilla/gecko/dlc/catalog/TestDownloadContentCatalog.java#60.  Do you see that locally?  (Also, that should be bootstrapper -- with two 'p' characters.)

::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/permissions/TestPermissions.java:209
(Diff revision 1)
> +        Permissions.onRequestPermissionsResult(activity, new String[0], new int[0]);

Ah, this confused me for a second, but I see it now.  Rock on.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Nick Alexander :nalexander from comment #2)
> BTW, I have a single failure in |mach gradle test|, in
> https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/
> background/junit4/src/org/mozilla/gecko/dlc/catalog/
> TestDownloadContentCatalog.java#60.  Do you see that locally?  (Also, that
> should be bootstrapper -- with two 'p' characters.)

Oh! I do not see that locally because this test only passes if you have fonts excluded (MOZ_ANDROID_EXCLUDE_FONTS). I'll fix that in a follow-up.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/63e8b3fd18f550ab35a4ac26c2169521a52365d5
Bug 1242443 - TestPermissions: Add test cases for non-Activity context, doNotPrompt() and doNotPromptIf(). r=nalexander

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63e8b3fd18f5