Closed Bug 1242467 Opened 7 years ago Closed 7 years ago

Give new onboarding experiments new names

Categories

(Firefox for Android Graveyard :: First Run, defect)

Product:
Firefox for Android Graveyard
Component:
First Run
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox46 fixed, firefox47 fixed, fennec46+)

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
fennec 46+ ---

People

(Reporter: Margaret, Assigned: liuche)

References

Details

Attachments

(2 files)

MozReview Request: Bug 1242467 - Give new onboarding experiments new names. r=margaret
58 bytes, text/x-review-board-request
Margaret
: review+
Details
Aurora Patch: Combined onboarding rename patch
8.11 KB, patch
liuche
: review+
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
We should not reuse "onboarding-a" and "onboarding-b" for the new experiments, since the same switchboard config is served to all versions of the app. Let's do something like "onboarding2-a", "onboarding2-b", "onboarding2-c". Or we could come up with more descriptive experiment names relating to this experiment, since I imagine we'll have lots of onboarding experiments in the future.

https://github.com/mozilla-services/switchboard-experiments/pull/3#issuecomment-174379913
tracking-fennec: --- → 46+
Attachment #8712826 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8712826 [details]
MozReview Request: Bug 1242467 - Give new onboarding experiments new names. r=margaret

https://reviewboard.mozilla.org/r/32667/#review29423

Thanks, I think this will be better for the long run to avoid confusion in the switchboard config.
https://hg.mozilla.org/mozilla-central/rev/536ef5666af4
https://hg.mozilla.org/mozilla-central/rev/7ce98a45886e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Reminder to request uplift.
Flags: needinfo?(liuche)
I combined these patches into one, because one was a hotfix for some missing imports.

Approval Request Comment
[Feature/regressing bug #]: Firstrun
[User impact if declined]: Naming of new onboarding will be overloaded
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: very low, variable renaming
[String/UUID change made/needed]: none
Flags: needinfo?(liuche)
Attachment #8719919 - Flags: review+
Attachment #8719919 - Flags: approval-mozilla-aurora?
Adding a dependency on another patch with Aurora uplift requested - this needs to be later on the queue, otherwise there will be conflicts.
Depends on: 1240549
Attachment #8719919 - Attachment description: Patch: Combined onboarding rename patch → Aurora Patch: Combined onboarding rename patch
Comment on attachment 8719919 [details] [diff] [review]
Aurora Patch: Combined onboarding rename patch

Renaming experiments for android, OK to uplift.
Attachment #8719919 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.