1242467 - Give new onboarding experiments new names

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: First Run, defect)

Description

[:Margaret Leibovic]

We should not reuse "onboarding-a" and "onboarding-b" for the new experiments, since the same switchboard config is served to all versions of the app. Let's do something like "onboarding2-a", "onboarding2-b", "onboarding2-c". Or we could come up with more descriptive experiment names relating to this experiment, since I imagine we'll have lots of onboarding experiments in the future.

https://github.com/mozilla-services/switchboard-experiments/pull/3#issuecomment-174379913

Comment 1

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1242467 - Give new onboarding experiments new names. r=margaret

Review commit: https://reviewboard.mozilla.org/r/32667/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32667/

Comment 2

[:Margaret Leibovic]

Comment on attachment 8712826 [details]
MozReview Request: Bug 1242467 - Give new onboarding experiments new names. r=margaret

https://reviewboard.mozilla.org/r/32667/#review29423

Thanks, I think this will be better for the long run to avoid confusion in the switchboard config.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/536ef5666af4

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7ce98a45886e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/536ef5666af4
https://hg.mozilla.org/mozilla-central/rev/7ce98a45886e

Comment 6

[:Margaret Leibovic]

Reminder to request uplift.

Comment 7

[Chenxia Liu [:liuche]]

Attachment: Aurora Patch: Combined onboarding rename patch

I combined these patches into one, because one was a hotfix for some missing imports.

Approval Request Comment
[Feature/regressing bug #]: Firstrun
[User impact if declined]: Naming of new onboarding will be overloaded
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: very low, variable renaming
[String/UUID change made/needed]: none

Comment 8

[Chenxia Liu [:liuche]]

Adding a dependency on another patch with Aurora uplift requested - this needs to be later on the queue, otherwise there will be conflicts.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8719919 [details] [diff] [review]
Aurora Patch: Combined onboarding rename patch

Renaming experiments for android, OK to uplift.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b5df3e5a52c8

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b5df3e5a52c8