Give new onboarding experiments new names

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: liuche)

Tracking

unspecified
Firefox 47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed, fennec46+)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
We should not reuse "onboarding-a" and "onboarding-b" for the new experiments, since the same switchboard config is served to all versions of the app. Let's do something like "onboarding2-a", "onboarding2-b", "onboarding2-c". Or we could come up with more descriptive experiment names relating to this experiment, since I imagine we'll have lots of onboarding experiments in the future.

https://github.com/mozilla-services/switchboard-experiments/pull/3#issuecomment-174379913
(Reporter)

Updated

3 years ago
tracking-fennec: --- → 46+
(Assignee)

Comment 1

3 years ago
Created attachment 8712826 [details]
MozReview Request: Bug 1242467 - Give new onboarding experiments new names. r=margaret

Review commit: https://reviewboard.mozilla.org/r/32667/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32667/
Attachment #8712826 - Flags: review?(margaret.leibovic)
(Reporter)

Updated

3 years ago
Attachment #8712826 - Flags: review?(margaret.leibovic) → review+
(Reporter)

Comment 2

3 years ago
Comment on attachment 8712826 [details]
MozReview Request: Bug 1242467 - Give new onboarding experiments new names. r=margaret

https://reviewboard.mozilla.org/r/32667/#review29423

Thanks, I think this will be better for the long run to avoid confusion in the switchboard config.

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/536ef5666af4
https://hg.mozilla.org/mozilla-central/rev/7ce98a45886e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
(Reporter)

Comment 6

3 years ago
Reminder to request uplift.
Flags: needinfo?(liuche)
(Assignee)

Comment 7

3 years ago
Created attachment 8719919 [details] [diff] [review]
Aurora Patch: Combined onboarding rename patch

I combined these patches into one, because one was a hotfix for some missing imports.

Approval Request Comment
[Feature/regressing bug #]: Firstrun
[User impact if declined]: Naming of new onboarding will be overloaded
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: very low, variable renaming
[String/UUID change made/needed]: none
Flags: needinfo?(liuche)
Attachment #8719919 - Flags: review+
Attachment #8719919 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 8

3 years ago
Adding a dependency on another patch with Aurora uplift requested - this needs to be later on the queue, otherwise there will be conflicts.
Depends on: 1240549
(Assignee)

Updated

3 years ago
Attachment #8719919 - Attachment description: Patch: Combined onboarding rename patch → Aurora Patch: Combined onboarding rename patch
Comment on attachment 8719919 [details] [diff] [review]
Aurora Patch: Combined onboarding rename patch

Renaming experiments for android, OK to uplift.
Attachment #8719919 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.