1242469 - Remove the "Enable worker debugging (in development)" checkbox from about:debugging

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect)

Description

[Jan Keromnes [:janx]]

This checkbox controls the "devtools.debugger.workers" pref, which we should remove as well.

Comment 1

[Jan Keromnes [:janx]]

Eddy, do you know what this pref controls? Can we get rid of it?

Comment 2

[Eddy Bruel [:ejpbruel]]

(In reply to Jan Keromnes [:janx] from comment #1)
> Eddy, do you know what this pref controls? Can we get rid of it?

That pref controls whether or not we show the worker debugger UI. I am reluctant to remove it at this point, mostly because I don't think that we offer a good user experience for worker debugging yet.

Comment 3

[Jan Keromnes [:janx]]

Attachment: Remove the "Enable worker debugging (in development)" checkbox from about:debugging.

Comment 4

[Jan Keromnes [:janx]]

Fair enough, thanks Eddy.

However, since it's related to debugging plain JS workers on a website, and not launching toolboxes on service workers from about:debugging, I'll remove the checkbox from about:debugging (another checkbox remains in the toolbox options) because it's misleading and confusing to users of about:debugging.

Comment 5

[Jan Keromnes [:janx]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e28cf14aad6a

Comment 6

[Jan Keromnes [:janx]]

Trivial patch with all-green try.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/acd0c697f16c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/acd0c697f16c

Comment 9

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 47.0a1 (2016-01-25) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Developer Edition 47.0a2!

Build ID: 20160414004009
User Agent: Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 Firefox/47.0

Comment 10

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 47.0a1 (Build ID: 20160125060632) on 
Windows 8.1, 64-bit.

Verified as fixed with Firefox Developer edition 47.0a2 (Build ID: 20160420004046)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0

As the bug is also verified on Linux (comment 9), I am marking this as verified!