1242479 - 'Open and Fill' from Login doesn't open the page to autofill login

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1471

STR:

1. Save a login for m.facebook.com from device
2. Navigate to login detail page from login list
3. Long press -> 'Open and Fill'

Expected:

Settings should minimize and launch new tab with login pre-fill.

Actual:

Nothing happens

----

After some initial exploration, the reason `Open and Fill` doesn't work is because when the login is saved, no formSubmitURL is stored which is required for opening/filling in a login.

Comment 1

[Stephan Leroux [:sleroux]]

Comment on attachment 8711667 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1471

Not sure how this PR got here...

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1497

1-liner

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: Private Tab Fix

Figured I would add this on top of this commit since it's related. This patch resolves the issue with performing 'Open & Fill' while in private mode. See https://bugzilla.mozilla.org/show_bug.cgi?id=1245872 for additional info.

Comment 4

[Emily Toop (:fluffyemily)]

Comment on attachment 8715995 [details]
Private Tab Fix

add a test for the normal case and we're flying.

Comment 5

[Stephan Leroux [:sleroux]]

master 696967ac51a8e049c3b10194e5db6b737f742bf7