1242567 - OptionsPanel.show should use Task to simplify its implementation

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

Followup of bug 1239287 comment 7.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df1cc821d623

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8711693 [details] [diff] [review]
patch v1

Review of attachment 8711693 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/framework/toolbox-options.js
@@ +99,3 @@
>      // For local debugging we need to make the target remote.
>      if (!this.target.isRemote) {
> +      this.target.makeRemote();

Should this be yielding?

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05e1bc2a9e28

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

(In reply to Brian Grinstead [:bgrins] from comment #3)
> Comment on attachment 8711693 [details] [diff] [review]
> patch v1
> 
> Review of attachment 8711693 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: devtools/client/framework/toolbox-options.js
> @@ +99,3 @@
> >      // For local debugging we need to make the target remote.
> >      if (!this.target.isRemote) {
> > +      this.target.makeRemote();
> 
> Should this be yielding?

Yes...

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8711763 [details] [diff] [review]
patch v2

Review of attachment 8711763 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks

Comment 7

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd00acdc48ba

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: patch v3

Forgot to also `return this;` at end of open.

Comment 9

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/a36366199462d51c8f7b3cf6ccce27f52fbedb34
Bug 1242567 - Cleanup OptionsPanel.open by using Task.async. r=bgrins

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a36366199462