OptionsPanel.show should use Task to simplify its implementation

RESOLVED FIXED in Firefox 47

Status

RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 47

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
Followup of bug 1239287 comment 7.
Comment on attachment 8711693 [details] [diff] [review]
patch v1

Review of attachment 8711693 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/framework/toolbox-options.js
@@ +99,3 @@
>      // For local debugging we need to make the target remote.
>      if (!this.target.isRemote) {
> +      this.target.makeRemote();

Should this be yielding?
(Assignee)

Comment 5

3 years ago
Created attachment 8711763 [details] [diff] [review]
patch v2

(In reply to Brian Grinstead [:bgrins] from comment #3)
> Comment on attachment 8711693 [details] [diff] [review]
> patch v1
> 
> Review of attachment 8711693 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: devtools/client/framework/toolbox-options.js
> @@ +99,3 @@
> >      // For local debugging we need to make the target remote.
> >      if (!this.target.isRemote) {
> > +      this.target.makeRemote();
> 
> Should this be yielding?

Yes...
Attachment #8711763 - Flags: review?(bgrinstead)
(Assignee)

Updated

3 years ago
Attachment #8711693 - Attachment is obsolete: true
Comment on attachment 8711763 [details] [diff] [review]
patch v2

Review of attachment 8711763 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks
Attachment #8711763 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 8

3 years ago
Created attachment 8712062 [details] [diff] [review]
patch v3

Forgot to also `return this;` at end of open.
Attachment #8712062 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8711763 - Attachment is obsolete: true

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a36366199462
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47

Updated

7 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.