Fix unhandled rejected promises in markup-view tests

RESOLVED FIXED in Firefox 47

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

unspecified
Firefox 47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
So far I think it's only these 2 tests:

devtools/client/markupview/test/browser_markupview_dragdrop_escapeKeyPress.js
devtools/client/markupview/test/browser_markupview_dragdrop_invalidNodes.js

But I'll later re-run the full test suite and see if other tests are failing too.
(Assignee)

Comment 1

2 years ago
Ok, I got the 2 first one fixed, but after running the full suite, I found out 2 more:
browser_markup_css_completion_style_attribute.js
browser_markup_navigation.js
Assignee: nobody → pbrosset
(Assignee)

Comment 2

2 years ago
Created attachment 8711830 [details] [diff] [review]
Bug_1242570_-_Fix_unhandled_promise_rejections_in_.diff
Attachment #8711830 - Flags: review?(bgrinstead)
Comment on attachment 8711830 [details] [diff] [review]
Bug_1242570_-_Fix_unhandled_promise_rejections_in_.diff

Review of attachment 8711830 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me
Attachment #8711830 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 4

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1193f24dd9d0&group_state=expanded&selectedJob=15914736

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/ffcd2cf17fac

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ffcd2cf17fac
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.