Closed
Bug 1242584
Opened 9 years ago
Closed 9 years ago
ESLint head.js importer should also process import-globals-from comments
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(2 files)
The head.js importer should carry over any globals from import-globals-from comments in the head file into the test files.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32519/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32519/
Attachment #8712376 -
Flags: review?(ttromey)
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32521/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32521/
Attachment #8712377 -
Flags: review?(ttromey)
Comment 3•9 years ago
|
||
Comment on attachment 8712376 [details]
MozReview Request: Bug 1242584 - Remove dead code in import-headjs-globals. r=tromey
https://reviewboard.mozilla.org/r/32519/#review29251
Great, thanks.
Attachment #8712376 -
Flags: review?(ttromey) → review+
Updated•9 years ago
|
Attachment #8712377 -
Flags: review?(ttromey) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8712377 [details]
MozReview Request: Bug 1242584 - import-globals-from should carry over to tests. r=tromey
https://reviewboard.mozilla.org/r/32521/#review29269
This seems good to me.
I was thinking perhaps the importing should be done elsewhere - but I re-read bug 1242893 and it isn't directly related to this spot, and in any case more changes can be done in the future if need be.
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bbcb79f256c4
https://hg.mozilla.org/mozilla-central/rev/59c5826c1280
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•