Closed Bug 1242584 Opened 9 years ago Closed 9 years ago

ESLint head.js importer should also process import-globals-from comments

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(2 files)

The head.js importer should carry over any globals from import-globals-from comments in the head file into the test files.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8712376 [details]
MozReview Request: Bug 1242584 - Remove dead code in import-headjs-globals. r=tromey

https://reviewboard.mozilla.org/r/32519/#review29251

Great, thanks.
Attachment #8712376 - Flags: review?(ttromey) → review+
Attachment #8712377 - Flags: review?(ttromey) → review+
Comment on attachment 8712377 [details]
MozReview Request: Bug 1242584 - import-globals-from should carry over to tests. r=tromey

https://reviewboard.mozilla.org/r/32521/#review29269

This seems good to me.

I was thinking perhaps the importing should be done elsewhere - but I re-read bug 1242893 and it isn't directly related to this spot, and in any case more changes can be done in the future if need be.
https://hg.mozilla.org/mozilla-central/rev/bbcb79f256c4
https://hg.mozilla.org/mozilla-central/rev/59c5826c1280
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: