Closed
Bug 1242617
Opened 8 years ago
Closed 8 years ago
Add webkit-prefixed aliases for CSS Mask Image properties ("-webkit-mask-image" and associated properties)
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Unassigned)
References
(Blocks 1 open bug)
Details
Filing this bug as a placeholder to cover support for CSS Mask Image properties So far, I think we're only aware of one site that depends on them -- Google's mobile results page, and there, *only* if we spoof a mobile webkit-based User Agent string: https://github.com/webcompat/web-bugs/issues/1911#issuecomment-174425819 ChromeStatus shows that "-webkit-mask-image" has 7.8% usage, though for all we know, authors might also be tending to provide standards-based fallback alongside it: https://www.chromestatus.com/metrics/css/popularity#webkit-mask-image Also, MS Edge does not support "mask-image" or "-webkit-mask-image" at this point. So, we should probably hold off on supporting the prefixed form of this property for the time being, until we've gotten better data on how much the web requires it.
Comment 1•8 years ago
|
||
Fixed in bug686281. webkit prefix alias support for mask-image property is covered in bug686281(0007-Bug-686281-Mask-CSS-webkit-alias-r-dbaron.patch) and controlled by pref "layout.css.prefixes.webkit" as well. The default value is false.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•8 years ago
|
||
OK, thanks! (Specifically, this was just fixed in this cset from bug 686281: http://hg.mozilla.org/mozilla-central/rev/f6eba571ce59 )
Reporter | ||
Comment 3•8 years ago
|
||
(And tests were added here: http://hg.mozilla.org/mozilla-central/diff/280c5933d1ce/layout/style/test/property_database.js#l1.254 )
Flags: in-testsuite+
Comment 4•8 years ago
|
||
I don't have a solid understanding of how the standard version maps to the prefixed version, but https://github.com/whatwg/compat/issues/14 exists to figure that out, and document it as such.
Comment 5•8 years ago
|
||
I think we might need to do a few tweaks to this set of aliases based on https://github.com/whatwg/compat/issues/14#issuecomment-177340371. I've got more testing (and learning to do), but will file follow up bugs + patches if that turns out to be the case.
Comment 6•8 years ago
|
||
Ah, looking more closely -- I thought we had left out the -webkit-mask-box-image-* -> mask-border-* aliases, but we don't support that yet. 877294 should be the bug for that work, I think (need to update title + old spec link)
Comment 7•8 years ago
|
||
Spec commit https://github.com/whatwg/compat/commit/d1ac0cf612d179f54fc9529ce4f31c595ba6cf7f (-webkit-mask-source-type alias was removed in a follow up commit).
You need to log in
before you can comment on or make changes to this bug.
Description
•