1242631 - Options shouldn't show tools that aren't supported for the current target

Status: RESOLVED WORKSFORME

(DevTools :: Framework, defect)

Description

[Brian Grinstead [:bgrins]]

STR:
Open the toolbox
Go to options panel
Look in "Default Firefox Developer Tools" section

Expected:
No "Scratchpad" with an asterisk

Actual:
There is an entry for "scratchpad" and a footer at the bottom of the column saying "not supported for the current toolbox target".  This is a lot of UI to indicate that something doesn't work.  Plus there's a checkbox that basically does nothing.

Comment 1

[Brian Grinstead [:bgrins]]

Helen, I'd like your opinion on this.  Any thoughts?

For more info - "Scratchpad" is supported in a WebIDE toolbox.  So checking the box in a normal toolbox would change the default value of it in that other toolbox.

Comment 2

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: Screen Shot 2016-01-25 at 3.06.02 PM.png

I agree that it's a little strange. Perhaps we could do something like in the attached screenshot?

If Scratchpad is unavailable for the current toolbox, we (1) disable the checkbox, (2) gray out scratchpad, and (3) move up the error to the same line as "Scratchpad" so people don't have to scroll to understand why it's disabled.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Helen V. Holmes (:helenvholmes) (:✨) from comment #2)
> Created attachment 8711821 [details]
> Screen Shot 2016-01-25 at 3.06.02 PM.png
> 
> I agree that it's a little strange. Perhaps we could do something like in
> the attached screenshot?
> 
> If Scratchpad is unavailable for the current toolbox, we (1) disable the
> checkbox, (2) gray out scratchpad, and (3) move up the error to the same
> line as "Scratchpad" so people don't have to scroll to understand why it's
> disabled.

That's definitely an improvement over the current situation.  The text will be super likely to wrap in some locales (maybe even in English) which will lead to a weird situation where the tool that isn't available ends up taking up the most space in the options panel.

I don't see a big benefit to including scratchpad at all (maybe for extensions that don't support certain targets it'd be helpful to see that it's not available though).  If we do want to, then maybe the greyed-out unchecked checkbox with a tooltip explaining that it's not supported would be enough.  What do you think?

Comment 4

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> I don't see a big benefit to including scratchpad at all (maybe for
> extensions that don't support certain targets it'd be helpful to see that
> it's not available though).  If we do want to, then maybe the greyed-out
> unchecked checkbox with a tooltip explaining that it's not supported would
> be enough.  What do you think?

I am fine with just not showing it 

Comment 5

[Patrick Brosset <:pbro>]

Scratchpad now appears without an asterisk, because it can be opened as a tab.
Let's close this.