1242636 - trim out pre-watershed linux and windows versions from update verify

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[[e-mail] (:bhearsum)]

We added a watershed for SHA-1 on Windows in the 43.0 cycle. On Linux, we're creating a watershed in the 44.0 for GTK changes. We should trim out these old versions from update verify since we don't support 42.0 and earlier -> 45.0 on Linux/Windows. 43.0 can be trimmed from Windows, too. This will make the tests run faster, and might let us simplify our Linux testing strategy by only testing GTK 3 versions of Firefox.

Assigning to Rail at his request.

Comment 1

[Rail Aliiev [:rail]]

Attachment: trim-tools.diff

win32/win64 watersheds:

Release: 43.0.1
Beta: 44.0b1
ESR: 38.5.1

TB Release: 38.5.0
TB Beta: 44.0b1

I also deleted unused esr31 files and problematic 41.0b1 release.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8712270 [details] [diff] [review]
trim-tools.diff

Review of attachment 8712270 [details] [diff] [review]:
-----------------------------------------------------------------

I think I'm missing something here...why are you adding to the <release> sections instead of removing past-update lines?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #2)
> Comment on attachment 8712270 [details] [diff] [review]
> trim-tools.diff
> 
> Review of attachment 8712270 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think I'm missing something here...why are you adding to the <release>
> sections instead of removing past-update lines?

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8712270 [details] [diff] [review]
trim-tools.diff

14:48 < rail> bhearsum: can you elaborate on your comment https://bugzilla.mozilla.org/show_bug.cgi?id=1242636#c2 ? not sure what you mean there...
14:49 <~bhearsum> rail: IIRC, past-update line are what control the releases we test in update verify
14:49 <~bhearsum> so if you want to trim out old versions from the list of tests, you need to remove them
14:50 < rail> I didn't want to remove all of them, just whatever is behind watersheds
14:51 < rail> in that case win32/win64 only
14:51 < rail> not touching other platforms
14:51 <~bhearsum> oh
14:51 <~bhearsum> hmm
14:51 <~bhearsum> i must've missed the past-update removals when i reviewed it before

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8712270 [details] [diff] [review]
trim-tools.diff

https://hg.mozilla.org/build/tools/rev/0c4da22d062d

to workaround the bitrot I had to:
  
  hg up --date "2016-01-26"
  hg import --no-commit "https://bugzilla.mozilla.org/attachment.cgi?id=8712270"
  hg diff -U3 > /tmp/meh.diff
  hg up -C default
  hg import /tmp/meh.diff