1242671 - remove winbuild and wintry from firewall-tests

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Amy Rich [:arr] [:arich]]

Attachment: remove-winbuild-wintest-firewall.diff

We've moved all of the windows building and try capacity into AWS so should remove those old networks form our firewall tests, etc. I'm putting up a patch that I think will works so that dustin else can review and land.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8711815 [details] [diff] [review]
remove-winbuild-wintest-firewall.diff

Review of attachment 8711815 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but note (a) that Callek still needs to fix up the tests after his routing change for :ewong, and (b) you'll want to land these about the same time the firewall rules themselves are changed to remove these subnets.

Comment 2

[Justin Wood (:Callek)]

The currently failing tests are (should be) fixed with the latest round in https://bugzilla.mozilla.org/show_bug.cgi?id=1242014#c10

I did already land the firewall test changes: * 0b09e43 - (3 days ago) Bug 1242014 - Support routing for seabld productdelivery upload host - Justin Wood (HEAD -> master, origin/master, origin/HEAD, fwunit1/master)

Comment 3

[:dhouse]

I confirmed that the tests from Bug 1242014 are not failing currently.

Patch changes covers all the entries for winbuild and wintry (wintest entries remain).

Applied patch as git commit #160b280 and pushed to master.
Fixed my typo in re-applying the patch (merge conflict in test_proxxy.py).

Pulled new latest master on fwunit1, ran tests with one change in the results:

> fwunit.analysis.sources: ERROR: policy LogAggregators/out+build-win-test/in+build-win-test/out+build/out+buildbot-master/out+dc_ad--services+default/out+global-dc-all+global-dc-any+global-releng-vpc--any+keysigners--buildbot-sign+local-10.0.22.0/30+local-10.0.22.4/30+local-10.26.36.0/22+nagios/out+netops-canary/out+netops2+proxxy-vpc-usw2/out+puppet-master/out+signing-worker/out+tests/out+try/out+unoccupied/out+wifimgr1--ANY+windows-ad-scl3 permits buildbot-sign traffic
> fwunit.analysis.sources: ERROR: policy LogAggregators/out+build-win-test/in+build-win-test/out+build/out+buildbot-master/out+dc_ad--services+default/out+global-dc-all+global-dc-any+global-releng-vpc--any+keysigners--buildbot-sign+local-10.0.22.0/30+local-10.0.22.4/30+local-10.26.44.0/22+nagios/out+netops-canary/out+netops2+proxxy-vpc-usw2/out+puppet-master/out+signing-worker/out+tests/out+try/out+unoccupied/out+wifimgr1--ANY+windows-ad-scl3 permits buildbot-sign traffic

I need to review if this is showing a change that needs to be made to the firewall.

Comment 4

[:dhouse]

I ran the tests with the previous version (before applying the patch) and they still show the wintest failure noted in comment #3. So that is not related to or caused by the removal of the wintry and winbuild tests.