1242717 - Add BHR coverage for all CPOW functions

Status: RESOLVED DUPLICATE of bug 1224374

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

Our CPOW histograms are Nightly-only, but we want to get extension performance information from the Beta 45 experiment. 

I propose we add BHR pseudostack annotations to all CPOW functions so we can track extension CPOW usage via BHR.

This is similar to bug 1224374 and will need uplifting to beta2 of Beta 45.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

I'm pretty sure I did this already in bug 1224374.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

As discussed with Vladan, I'm not 100% sure that I cover everything.

I have instrumented all the methods of the CPOWWrapper. Can someone thing of something that this may be missing, for instance on the content-side?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

I meant CPOWProxyHandler.

Comment 4

[Jim Mathies [:jimm]]

billm or mconley can answer this.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Deferring to billm, who definitely knows more about the underlying CPOW infrastructure. If he's unavailable, I'd ask mrbkap next.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This is the only place you should need to instrument:
https://dxr.mozilla.org/mozilla-central/source/js/ipc/WrapperOwner.cpp#158
It will cover CPOWs in both directions.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Ok, so since I did that already in bug 1224374, we're done. Thanks.