1242722 - Remove clang-cl command-line argument workarounds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:ehsan akhgari]

In https://llvm.org/bugs/show_bug.cgi?id=26090, we changed the default
behavior of clang-cl to accept unknown command line arguments.  This
patch removes the Firefox workaround for this issue.

Comment 1

[:ehsan akhgari]

Attachment: Remove clang-cl command-line argument workarounds

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8711858 [details] [diff] [review]
Remove clang-cl command-line argument workarounds

Review of attachment 8711858 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe we'd want to add a version test on clang-cl?

Comment 3

[:ehsan akhgari]

(In reply to Mike Hommey [:glandium] from comment #2)
> Maybe we'd want to add a version test on clang-cl?

We still don't support anything older than the tip of tree.  :-)  Various things will be broken if someone tries anything older.

I'm hoping that maybe 3.9 will end up being the first clang-cl release that we fully support, but 3.8 was just branched a week ago or so...

Comment 4

[:ehsan akhgari]

CCing people who build with clang.  You want to be at ToT!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08f0995ef873

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/08f0995ef873