Closed Bug 1242722 Opened 4 years ago Closed 4 years ago

Remove clang-cl command-line argument workarounds

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: ehsan, Unassigned)

References

Details

Attachments

(1 file)

In https://llvm.org/bugs/show_bug.cgi?id=26090, we changed the default
behavior of clang-cl to accept unknown command line arguments.  This
patch removes the Firefox workaround for this issue.
Attachment #8711858 - Flags: review?(mh+mozilla)
Blocks: winclang
Comment on attachment 8711858 [details] [diff] [review]
Remove clang-cl command-line argument workarounds

Review of attachment 8711858 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe we'd want to add a version test on clang-cl?
Attachment #8711858 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #2)
> Maybe we'd want to add a version test on clang-cl?

We still don't support anything older than the tip of tree.  :-)  Various things will be broken if someone tries anything older.

I'm hoping that maybe 3.9 will end up being the first clang-cl release that we fully support, but 3.8 was just branched a week ago or so...
CCing people who build with clang.  You want to be at ToT!
https://hg.mozilla.org/mozilla-central/rev/08f0995ef873
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Target Milestone: mozilla46 → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.