Closed
Bug 1242722
Opened 5 years ago
Closed 5 years ago
Remove clang-cl command-line argument workarounds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: ehsan, Unassigned)
References
Details
Attachments
(1 file)
4.91 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
In https://llvm.org/bugs/show_bug.cgi?id=26090, we changed the default behavior of clang-cl to accept unknown command line arguments. This patch removes the Firefox workaround for this issue.
Reporter | ||
Comment 1•5 years ago
|
||
Attachment #8711858 -
Flags: review?(mh+mozilla)
Comment 2•5 years ago
|
||
Comment on attachment 8711858 [details] [diff] [review] Remove clang-cl command-line argument workarounds Review of attachment 8711858 [details] [diff] [review]: ----------------------------------------------------------------- Maybe we'd want to add a version test on clang-cl?
Attachment #8711858 -
Flags: review?(mh+mozilla) → review+
Reporter | ||
Comment 3•5 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2) > Maybe we'd want to add a version test on clang-cl? We still don't support anything older than the tip of tree. :-) Various things will be broken if someone tries anything older. I'm hoping that maybe 3.9 will end up being the first clang-cl release that we fully support, but 3.8 was just branched a week ago or so...
Reporter | ||
Comment 4•5 years ago
|
||
CCing people who build with clang. You want to be at ToT!
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/08f0995ef873
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•5 years ago
|
Target Milestone: mozilla46 → mozilla47
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•