Make MDSM::mDecodedVideoEndTime zero-based

RESOLVED FIXED in Firefox 47

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The same reason as bug 1242841.
(Assignee)

Comment 2

2 years ago
Created attachment 8712001 [details]
MozReview Request: Bug 1242843 - Make MDSM::mDecodedVideoEndTime zero-based. r=kikuo.

Review commit: https://reviewboard.mozilla.org/r/32401/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32401/
Attachment #8712001 - Flags: review?(kikuo)
Comment on attachment 8712001 [details]
MozReview Request: Bug 1242843 - Make MDSM::mDecodedVideoEndTime zero-based. r=kikuo.

https://reviewboard.mozilla.org/r/32401/#review29297

::: dom/media/MediaDecoderStateMachine.cpp:904
(Diff revision 1)
> -  mDecodedVideoEndTime = video ? video->GetEndTime() : mDecodedVideoEndTime;
> +  mDecodedVideoEndTime = video->GetEndTime();

It seems that no one even check the return value of |AdjustForStartTIme()|, is there any case in which the value from |video->GetEndTime()| becomes negative after |AdjustForStartTIme()|, i.e. badly muxed media file ?
Attachment #8712001 - Flags: review?(kikuo)
(Assignee)

Comment 4

2 years ago
https://reviewboard.mozilla.org/r/32401/#review29297

> It seems that no one even check the return value of |AdjustForStartTIme()|, is there any case in which the value from |video->GetEndTime()| becomes negative after |AdjustForStartTIme()|, i.e. badly muxed media file ?

All video timestamps (start and end time) should be >= 0 after adjustment. However, we can't be sure of that for a badly muxed file. Therefore, we drop and won't render video frames with abnormal timestamps in VideoSink.
Comment on attachment 8712001 [details]
MozReview Request: Bug 1242843 - Make MDSM::mDecodedVideoEndTime zero-based. r=kikuo.

https://reviewboard.mozilla.org/r/32401/#review29311
Attachment #8712001 - Flags: review+
(Assignee)

Comment 6

2 years ago
Thanks!

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3ff4bda55715
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.