1242843 - Make MDSM::mDecodedVideoEndTime zero-based

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

The same reason as bug 1242841.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f380d61359e6

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1242843 - Make MDSM::mDecodedVideoEndTime zero-based. r=kikuo.

Review commit: https://reviewboard.mozilla.org/r/32401/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32401/

Comment 3

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8712001 [details]
MozReview Request: Bug 1242843 - Make MDSM::mDecodedVideoEndTime zero-based. r=kikuo.

https://reviewboard.mozilla.org/r/32401/#review29297

::: dom/media/MediaDecoderStateMachine.cpp:904
(Diff revision 1)
> -  mDecodedVideoEndTime = video ? video->GetEndTime() : mDecodedVideoEndTime;
> +  mDecodedVideoEndTime = video->GetEndTime();

It seems that no one even check the return value of |AdjustForStartTIme()|, is there any case in which the value from |video->GetEndTime()| becomes negative after |AdjustForStartTIme()|, i.e. badly muxed media file ?

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/32401/#review29297

> It seems that no one even check the return value of |AdjustForStartTIme()|, is there any case in which the value from |video->GetEndTime()| becomes negative after |AdjustForStartTIme()|, i.e. badly muxed media file ?

All video timestamps (start and end time) should be >= 0 after adjustment. However, we can't be sure of that for a badly muxed file. Therefore, we drop and won't render video frames with abnormal timestamps in VideoSink.

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8712001 [details]
MozReview Request: Bug 1242843 - Make MDSM::mDecodedVideoEndTime zero-based. r=kikuo.

https://reviewboard.mozilla.org/r/32401/#review29311

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff4bda55715

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ff4bda55715

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ff4bda55715