Closed Bug 1242890 Opened 4 years ago Closed 4 years ago

TEST-UNEXPECTED-ERROR | test_fallback_update.py TestFallbackUpdate.test_update | AttributeError: 'TestFallbackUpdate' object has no attribute 'download'

Categories

(Testing :: Firefox UI Tests, defect)

45 Branch
defect
Not set

Tracking

(firefox44 fixed, firefox45 fixed, firefox46 fixed, firefox47 fixed, firefox-esr38 wontfix)

RESOLVED FIXED
mozilla47
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed
firefox-esr38 --- wontfix

People

(Reporter: whimboo, Assigned: whimboo)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Follow-up for bug 1236569 which didn't fix all the cases for both types of update tests. That means we still have call to `self.download()`, which does not exist.

 06:16:15     INFO - Traceback (most recent call last):
 06:16:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 344, in run
 06:16:15     INFO -     testMethod()
 06:16:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/firefox_ui_tests/update/fallback/test_fallback_update.py", line 28, in test_update
 06:16:15     INFO -     self._test_update()
 06:16:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/firefox_ui_tests/update/fallback/test_fallback_update.py", line 22, in _test_update
 06:16:15     INFO -     self.download_and_apply_forced_update()
 06:16:15     INFO -   File "/home/mozauto/jenkins/workspace/mozilla-central_update/build/venv/local/lib/python2.7/site-packages/firefox_puppeteer/testcases/update.py", line 333, in download_and_apply_forced_update
 06:16:15     INFO -     self.download(about_window)

Actually this has to be `self.download_update()` similar to the direct update.
Attached file Github PR
Attachment #8712059 - Flags: review?(mjzffr)
Attachment #8712059 - Flags: review?(mjzffr) → review+
Attached patch Patch for hg.moSplinter Review
No code change, just adapted paths for the landing on hg.mo. So taking over r+.
Attachment #8713164 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/024b3a422b76
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Small fix for our update tests which we definitely need for the 45esr branch. So please get this patch landed on aurora and beta too.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.