Closed Bug 1242943 Opened 4 years ago Closed 4 years ago

[e10s] Enable browser_webconsole_clickable_urls.js for e10s

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(e10s+, firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
e10s + ---
firefox47 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Bug1242943.patch (obsolete) — Splinter Review
This test is on the e10s test list.

This patch:

- uses add_task
- switches from loadTab to BrowserTestUtils.openNewForegroundTab

TBH, I'm not sure whether this will fix the problem. This test passes in e10s mode on my local, so I'm assuming it's an intermittent. I'm not sure the best way to conclusively determine if it's fixed.
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Attachment #8712142 - Flags: review?(bgrinstead)
Blocks: e10s-tests
tracking-e10s: --- → +
Attachment #8712142 - Flags: review?(bgrinstead) → review+
(In reply to Lin Clark from comment #1)
> TBH, I'm not sure whether this will fix the problem. This test passes in
> e10s mode on my local, so I'm assuming it's an intermittent. I'm not sure
> the best way to conclusively determine if it's fixed.

A try push with a fair number of retriggers on all platforms on the dt chunk that this test is running in should be enough.

We could also do requestLongerTimeout here if needed since the test logic is simple - it's just that there might be too many test cases for linux debug.  Randomly choosing where to split up the test cases into a second test file seems worse than just requesting more time if we need it.
No longer blocks: 1112599
Blocks: 1112599
The comment next to the skip-if says that it's a linux debug timeout, so I don't think there's a good way to test that this change worked yet. I've blocked it on Bug 1242986.
Depends on: 1242986
Attached patch Bug1242943.patchSplinter Review
I'm not sure there is a good way to test this, or whether there will be. I'm going to go ahead and check it in. If it doesn't reduce the intermittents, then we can tackle it again in another issue.
Attachment #8712142 - Attachment is obsolete: true
Attachment #8723371 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0163992fcba2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Blocks: 1242986
No longer depends on: 1242986
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.