Closed Bug 1242966 Opened 4 years ago Closed 4 years ago

Make services/crypto eslintable

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: hectorz, Assigned: hectorz)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 1242977
Attachment #8712166 - Flags: review?(rnewman) → review+
Comment on attachment 8712166 [details]
MozReview Request: Bug 1242966 - Make services/crypto eslintable. r?rnewman

https://reviewboard.mozilla.org/r/32453/#review29249

Nice.

::: services/crypto/modules/WeaveCrypto.js:10
(Diff revision 1)
> +var Cu = Components.utils;

You can change these four lines into a destructuring bind:

```
const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components;
```
Attached patch Patch, updatedSplinter Review
(In reply to Richard Newman [:rnewman] from comment #2)
> 
> ::: services/crypto/modules/WeaveCrypto.js:10
> (Diff revision 1)
> > +var Cu = Components.utils;
> 
> You can change these four lines into a destructuring bind:
> 
> ```
> const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components;
> ```

Done, carry over r+.

Attach as a patch since reviewboard-hg is down.
Attachment #8713488 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/adf78202a5bb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.