Make services/crypto eslintable

RESOLVED FIXED in Firefox 47

Status

Cloud Services
Firefox Sync: Crypto
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: hectorz, Assigned: hectorz)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Blocks: 1242977
(Assignee)

Comment 1

2 years ago
Created attachment 8712166 [details]
MozReview Request: Bug 1242966 - Make services/crypto eslintable. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/32453/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32453/
Attachment #8712166 - Flags: review?(rnewman)
Attachment #8712166 - Flags: review?(rnewman) → review+
Comment on attachment 8712166 [details]
MozReview Request: Bug 1242966 - Make services/crypto eslintable. r?rnewman

https://reviewboard.mozilla.org/r/32453/#review29249

Nice.

::: services/crypto/modules/WeaveCrypto.js:10
(Diff revision 1)
> +var Cu = Components.utils;

You can change these four lines into a destructuring bind:

```
const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components;
```
(Assignee)

Comment 3

2 years ago
Created attachment 8713488 [details] [diff] [review]
Patch, updated

(In reply to Richard Newman [:rnewman] from comment #2)
> 
> ::: services/crypto/modules/WeaveCrypto.js:10
> (Diff revision 1)
> > +var Cu = Components.utils;
> 
> You can change these four lines into a destructuring bind:
> 
> ```
> const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components;
> ```

Done, carry over r+.

Attach as a patch since reviewboard-hg is down.
Attachment #8713488 - Flags: review+
(Assignee)

Comment 4

2 years ago
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28310e63182c
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/adf78202a5bb
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/adf78202a5bb
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.