Closed Bug 1242972 Opened 4 years ago Closed 4 years ago

Make services/fxaccounts eslintable

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: hectorz, Assigned: hectorz)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 1242977
Flags: firefox-backlog+
Priority: -- → P1
Attachment #8712170 - Flags: review?(markh) → review+
Comment on attachment 8712170 [details]
MozReview Request: Bug 1242972 - Make services/fxaccounts eslintable. r?markh

https://reviewboard.mozilla.org/r/32457/#review29533

LGTM, thanks! Is there another bug to enable this in the global .eslintignore file?

::: services/fxaccounts/FxAccountsStorage.jsm:551
(Diff revision 1)
> +      } else {

let's kill this else after the throw.

::: services/fxaccounts/FxAccountsStorage.jsm:589
(Diff revision 1)
> +      } else {

ditto here
Attached patch Patch, updatedSplinter Review
(In reply to Mark Hammond [:markh] from comment #2)
> 
> LGTM, thanks! Is there another bug to enable this in the global
> .eslintignore file?

My plan is to enable it in bug 1242977 once bug 1242973 also gets reviewed.

Attach as a patch since reviewboard-hg is down.
Attachment #8713489 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/06d321aaa350
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.