1242972 - Make services/fxaccounts eslintable

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Comment 1

[Hector Zhao [:hectorz]]

Attachment: MozReview Request: Bug 1242972 - Make services/fxaccounts eslintable. r?markh

Review commit: https://reviewboard.mozilla.org/r/32457/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32457/

Comment 2

[Mark Hammond [:markh]]

Comment on attachment 8712170 [details]
MozReview Request: Bug 1242972 - Make services/fxaccounts eslintable. r?markh

https://reviewboard.mozilla.org/r/32457/#review29533

LGTM, thanks! Is there another bug to enable this in the global .eslintignore file?

::: services/fxaccounts/FxAccountsStorage.jsm:551
(Diff revision 1)
> +      } else {

let's kill this else after the throw.

::: services/fxaccounts/FxAccountsStorage.jsm:589
(Diff revision 1)
> +      } else {

ditto here

Comment 3

[Hector Zhao [:hectorz]]

Attachment: Patch, updated

(In reply to Mark Hammond [:markh] from comment #2)
> 
> LGTM, thanks! Is there another bug to enable this in the global
> .eslintignore file?

My plan is to enable it in bug 1242977 once bug 1242973 also gets reviewed.

Attach as a patch since reviewboard-hg is down.

Comment 4

[Hector Zhao [:hectorz]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28310e63182c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/06d321aaa350

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/06d321aaa350