If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make services/fxaccounts eslintable

RESOLVED FIXED in Firefox 47

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: hectorz, Assigned: hectorz)

Tracking

unspecified
Firefox 47
Points:
---
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Blocks: 1242977
(Assignee)

Comment 1

2 years ago
Created attachment 8712170 [details]
MozReview Request: Bug 1242972 - Make services/fxaccounts eslintable. r?markh

Review commit: https://reviewboard.mozilla.org/r/32457/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32457/
Attachment #8712170 - Flags: review?(markh)
Flags: firefox-backlog+
Priority: -- → P1

Updated

2 years ago
Attachment #8712170 - Flags: review?(markh) → review+
Comment on attachment 8712170 [details]
MozReview Request: Bug 1242972 - Make services/fxaccounts eslintable. r?markh

https://reviewboard.mozilla.org/r/32457/#review29533

LGTM, thanks! Is there another bug to enable this in the global .eslintignore file?

::: services/fxaccounts/FxAccountsStorage.jsm:551
(Diff revision 1)
> +      } else {

let's kill this else after the throw.

::: services/fxaccounts/FxAccountsStorage.jsm:589
(Diff revision 1)
> +      } else {

ditto here
(Assignee)

Comment 3

2 years ago
Created attachment 8713489 [details] [diff] [review]
Patch, updated

(In reply to Mark Hammond [:markh] from comment #2)
> 
> LGTM, thanks! Is there another bug to enable this in the global
> .eslintignore file?

My plan is to enable it in bug 1242977 once bug 1242973 also gets reviewed.

Attach as a patch since reviewboard-hg is down.
Attachment #8713489 - Flags: review+
(Assignee)

Comment 4

2 years ago
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28310e63182c
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/06d321aaa350
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/06d321aaa350
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.