Status
()
People
(Reporter: hectorz, Assigned: hectorz)
Tracking
Firefox Tracking Flags
(firefox47 fixed)
Details
Attachments
(2 attachments)
Comment hidden (empty) |
(Assignee) | ||
Comment 1•3 years ago
|
||
Created attachment 8712170 [details] MozReview Request: Bug 1242972 - Make services/fxaccounts eslintable. r?markh Review commit: https://reviewboard.mozilla.org/r/32457/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32457/
Attachment #8712170 -
Flags: review?(markh)
Updated•3 years ago
|
Flags: firefox-backlog+
Priority: -- → P1
Updated•3 years ago
|
Attachment #8712170 -
Flags: review?(markh) → review+
Comment 2•3 years ago
|
||
Comment on attachment 8712170 [details] MozReview Request: Bug 1242972 - Make services/fxaccounts eslintable. r?markh https://reviewboard.mozilla.org/r/32457/#review29533 LGTM, thanks! Is there another bug to enable this in the global .eslintignore file? ::: services/fxaccounts/FxAccountsStorage.jsm:551 (Diff revision 1) > + } else { let's kill this else after the throw. ::: services/fxaccounts/FxAccountsStorage.jsm:589 (Diff revision 1) > + } else { ditto here
(Assignee) | ||
Comment 3•3 years ago
|
||
Created attachment 8713489 [details] [diff] [review] Patch, updated (In reply to Mark Hammond [:markh] from comment #2) > > LGTM, thanks! Is there another bug to enable this in the global > .eslintignore file? My plan is to enable it in bug 1242977 once bug 1242973 also gets reviewed. Attach as a patch since reviewboard-hg is down.
Attachment #8713489 -
Flags: review+
(Assignee) | ||
Comment 4•3 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28310e63182c
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/06d321aaa350
Keywords: checkin-needed
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/06d321aaa350
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in
before you can comment on or make changes to this bug.