Closed Bug 1242991 Opened 4 years ago Closed 4 years ago

aurora branch fails to build against system libvpx after this week's merge

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

46 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 + fixed
firefox47 --- fixed

People

(Reporter: ht990332, Assigned: karlt)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160122190221

Steps to reproduce:

aurora branch fails to build against system libvpx after this week's merge. this was working on 45b2.
I tried with both gcc and clang and both --enable-gold and --disable-gold.
All result in this error.


Actual results:

92:27.05     INPUT("../../gfx/skia/Unified_cpp_gfx_skia26.o")
92:27.05     INPUT("../../gfx/skia/Unified_cpp_gfx_skia27.o")
92:27.05     INPUT("../../gfx/skia/Unified_cpp_gfx_skia3.o")
92:27.05     INPUT("../../gfx/skia/Unified_cpp_gfx_skia4.o")
92:27.05     INPUT("../../gfx/skia/Unified_cpp_gfx_skia5.o")
92:27.05     INPUT("../../gfx/skia/Unified_cpp_gfx_skia6.o")
92:27.05     INPUT("../../gfx/skia/Unified_cpp_gfx_skia7.o")
92:27.06     INPUT("../../gfx/skia/Unified_cpp_gfx_skia8.o")
92:27.06     INPUT("../../gfx/skia/Unified_cpp_gfx_skia9.o")
92:27.06     INPUT("StaticXULComponentsEnd/StaticXULComponentsEnd.o")
92:27.06 
92:27.06 ../../dom/media/encoder/Unified_cpp_dom_media_encoder0.o: In function `~VP8TrackEncoder':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/encoder/VP8TrackEncoder.cpp:45: undefined reference to `vpx_codec_destroy'
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/encoder/VP8TrackEncoder.cpp:49: undefined reference to `vpx_img_free'
92:27.06 ../../dom/media/encoder/Unified_cpp_dom_media_encoder0.o: In function `mozilla::VP8TrackEncoder::Init(int, int, int, int, int)':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/encoder/VP8TrackEncoder.cpp:76: undefined reference to `vpx_codec_enc_config_default'
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/encoder/VP8TrackEncoder.cpp:83: undefined reference to `vpx_img_wrap'
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/encoder/VP8TrackEncoder.cpp:128: undefined reference to `vpx_codec_enc_init_ver'
92:27.06 ../../dom/media/encoder/Unified_cpp_dom_media_encoder0.o: In function `vpx_codec_control_VP8E_SET_STATIC_THRESHOLD(vpx_codec_ctx*, int, unsigned int)':
92:27.06 /usr/include/vpx/vp8cx.h:734: undefined reference to `vpx_codec_control_'
92:27.06 ../../dom/media/encoder/Unified_cpp_dom_media_encoder0.o: In function `vpx_codec_control_VP8E_SET_CPUUSED(vpx_codec_ctx*, int, int)':
92:27.06 /usr/include/vpx/vp8cx.h:726: undefined reference to `vpx_codec_control_'
92:27.06 ../../dom/media/encoder/Unified_cpp_dom_media_encoder0.o: In function `vpx_codec_control_VP8E_SET_TOKEN_PARTITIONS(vpx_codec_ctx*, int, int)':
92:27.06 /usr/include/vpx/vp8cx.h:736: undefined reference to `vpx_codec_control_'
92:27.06 ../../dom/media/encoder/Unified_cpp_dom_media_encoder0.o: In function `mozilla::VP8TrackEncoder::GetEncodedTrack(mozilla::EncodedFrameContainer&)':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/encoder/VP8TrackEncoder.cpp:585: undefined reference to `vpx_codec_encode'
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/encoder/VP8TrackEncoder.cpp:632: undefined reference to `vpx_codec_encode'
92:27.06 ../../dom/media/platforms/Unified_cpp_dom_media_platforms0.o: In function `mozilla::VPXDecoder::Shutdown()':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/dom/media/platforms/agnostic/VPXDecoder.cpp:53: undefined reference to `vpx_codec_destroy'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8EncoderImpl::Release()':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:149: undefined reference to `vpx_codec_destroy'
92:27.06 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:158: undefined reference to `vpx_img_free'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8EncoderImpl::SetRates(unsigned int, unsigned int)':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:261: undefined reference to `vpx_codec_enc_config_set'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8EncoderImpl::InitEncode(webrtc::VideoCodec const*, int, unsigned long)':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:445: undefined reference to `vpx_codec_enc_config_default'
92:27.06 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:554: undefined reference to `vpx_img_wrap'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8EncoderImpl::InitAndSetControlSettings()':
92:27.06 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:659: undefined reference to `vpx_codec_enc_init_ver'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8E_SET_NOISE_SENSITIVITY(vpx_codec_ctx*, int, unsigned int)':
92:27.06 /usr/include/vpx/vp8cx.h:730: undefined reference to `vpx_codec_control_'
92:27.06 /usr/include/vpx/vp8cx.h:730: undefined reference to `vpx_codec_control_'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8E_SET_STATIC_THRESHOLD(vpx_codec_ctx*, int, unsigned int)':
92:27.06 /usr/include/vpx/vp8cx.h:734: undefined reference to `vpx_codec_control_'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8E_SET_CPUUSED(vpx_codec_ctx*, int, int)':
92:27.06 /usr/include/vpx/vp8cx.h:726: undefined reference to `vpx_codec_control_'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8E_SET_TOKEN_PARTITIONS(vpx_codec_ctx*, int, int)':
92:27.06 /usr/include/vpx/vp8cx.h:736: undefined reference to `vpx_codec_control_'
92:27.06 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o:/usr/include/vpx/vp8cx.h:762: more undefined references to `vpx_codec_control_' follow
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8EncoderImpl::Encode(webrtc::I420VideoFrame const&, webrtc::CodecSpecificInfo const*, std::vector<webrtc::VideoFrameType, std::allocator<webrtc::VideoFrameType> > const*)':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:891: undefined reference to `vpx_codec_encode'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8E_SET_MAX_INTRA_BITRATE_PCT(vpx_codec_ctx*, int, unsigned int)':
92:27.07 /usr/include/vpx/vp8cx.h:762: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8E_SET_CPUUSED(vpx_codec_ctx*, int, int)':
92:27.07 /usr/include/vpx/vp8cx.h:726: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8EncoderImpl::UpdateCodecFrameSize(webrtc::I420VideoFrame const&)':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:924: undefined reference to `vpx_codec_enc_config_set'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8E_GET_LAST_QUANTIZER_64(vpx_codec_ctx*, int, int*)':
92:27.07 /usr/include/vpx/vp8cx.h:757: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8_SET_POSTPROC(vpx_codec_ctx*, int, vp8_postproc_cfg*)':
92:27.07 /usr/include/vpx/./vp8.h:128: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8D_GET_LAST_REF_UPDATES(vpx_codec_ctx*, int, int*)':
92:27.07 /usr/include/vpx/vp8dx.h:159: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8D_GET_FRAME_CORRUPTED(vpx_codec_ctx*, int, int*)':
92:27.07 /usr/include/vpx/vp8dx.h:161: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8DecoderImpl::Release()':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1378: undefined reference to `vpx_codec_destroy'
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1385: undefined reference to `vpx_img_free'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `webrtc::VP8DecoderImpl::Copy()':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1432: undefined reference to `vpx_img_free'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8_COPY_REFERENCE(vpx_codec_ctx*, int, vpx_ref_frame*)':
92:27.07 /usr/include/vpx/./vp8.h:126: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_webrtc_vp8/Unified_cpp_codecs_vp80.o: In function `vpx_codec_control_VP8_SET_REFERENCE(vpx_codec_ctx*, int, vpx_ref_frame*)':
92:27.07 /usr/include/vpx/./vp8.h:124: undefined reference to `vpx_codec_control_'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `webrtc::VP9EncoderImpl::Release()':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:101: undefined reference to `vpx_codec_destroy'
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:112: undefined reference to `vpx_img_free'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `webrtc::VP9EncoderImpl::SetRates(unsigned int, unsigned int)':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:228: undefined reference to `vpx_codec_enc_config_set'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `webrtc::VP9EncoderImpl::InitEncode(webrtc::VideoCodec const*, int, unsigned long)':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:293: undefined reference to `vpx_img_wrap'
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:296: undefined reference to `vpx_codec_vp9_cx'
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:296: undefined reference to `vpx_codec_enc_config_default'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `webrtc::VP9EncoderImpl::InitAndSetControlSettings(webrtc::VideoCodec const*)':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:427: undefined reference to `vpx_codec_vp9_cx'
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:427: undefined reference to `vpx_codec_enc_init_ver'
92:27.07 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `vpx_codec_control_VP8E_SET_CPUUSED(vpx_codec_ctx*, int, int)':
92:27.07 /home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:678: undefined reference to `vpx_codec_control_'
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `vpx_codec_control_VP8E_SET_MAX_INTRA_BITRATE_PCT(vpx_codec_ctx*, int, unsigned int)':
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:698: undefined reference to `vpx_codec_control_'
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `vpx_codec_control_VP9E_SET_AQ_MODE(vpx_codec_ctx*, int, unsigned int)':
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:709: undefined reference to `vpx_codec_control_'
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `vpx_codec_control_VP9E_SET_SVC(vpx_codec_ctx*, int, int)':
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:673: undefined reference to `vpx_codec_control_'
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `vpx_codec_control_VP9E_SET_SVC_PARAMETERS(vpx_codec_ctx*, int, void*)':
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:674: undefined reference to `vpx_codec_control_'
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o:/home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:675: more undefined references to `vpx_codec_control_' follow
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `webrtc::VP9EncoderImpl::Encode(webrtc::I420VideoFrame const&, webrtc::CodecSpecificInfo const*, std::vector<webrtc::VideoFrameType, std::allocator<webrtc::VideoFrameType> > const*)':
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:552: undefined reference to `vpx_codec_encode'
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `vpx_codec_control_VP9E_GET_SVC_LAYER_ID(vpx_codec_ctx*, int, vpx_svc_layer_id*)':
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:696: undefined reference to `vpx_codec_control_'
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/libvpx/vpx/vp8cx.h:696: undefined reference to `vpx_codec_control_'
92:27.08 ../../media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.o: In function `webrtc::VP9DecoderImpl::Release()':
92:27.08 /home/hussam/src/firefox/src/gecko-dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:998: undefined reference to `vpx_codec_destroy'
92:27.08 /usr/bin/ld: libxul.so: hidden symbol `vpx_codec_vp9_cx' isn't defined
92:27.08 /usr/bin/ld: final link failed: Bad value
92:27.08 clang-3.7: error: linker command failed with exit code 1 (use -v to see invocation)
92:27.08 /home/hussam/src/firefox/src/gecko-dev/config/rules.mk:834: recipe for target 'libxul.so' failed
92:27.08 make[5]: *** [libxul.so] Error 1
92:27.08 /home/hussam/src/firefox/src/gecko-dev/config/recurse.mk:71: recipe for target 'toolkit/library/target' failed
92:27.08 make[4]: *** [toolkit/library/target] Error 2
92:27.08 /home/hussam/src/firefox/src/gecko-dev/config/recurse.mk:32: recipe for target 'compile' failed
92:27.08 make[3]: *** [compile] Error 2
92:27.08 /home/hussam/src/firefox/src/gecko-dev/config/rules.mk:557: recipe for target 'default' failed
92:27.08 make[2]: *** [default] Error 2
92:27.08 /home/hussam/src/firefox/src/gecko-dev/client.mk:396: recipe for target 'realbuild' failed
92:27.08 make[1]: *** [realbuild] Error 2
92:27.08 client.mk:171: recipe for target 'build' failed
92:27.08 make: *** [build] Error 2
92:27.09 301 compiler warnings present.
92:29.81 Notification center failed: Install the python dbus module to get a notification when the build finishes.
Component: Untriaged → Build Config
Product: Firefox → Core
(retriage to Audio/Video if need be)
Adding #error "Wrong vpx_codec.h" to media/libvpx/vpx/vpx_codec.h

 0:13.09 In file included from /mnt/ssd1/karl/moz/dev/media/libvpx/vpx/././vp8.h:33:0,
 0:13.09                  from /mnt/ssd1/karl/moz/dev/media/libvpx/vpx/./vp8cx.h:18,
 0:13.09                  from /mnt/ssd1/karl/moz/dev/media/libvpx/vpx/svc_context.h:19,
 0:13.09                  from /mnt/ssd1/karl/moz/dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:18,
 0:13.09                  from /mnt/ssd1/karl/moz/dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/screenshare_layers.h:13,
 0:13.09                  from /mnt/ssd1/karl/moz/dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/screenshare_layers.cc:11,
 0:13.09                  from /mnt/sda11/karl/obj/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.cpp:2:
 0:13.09 /mnt/ssd1/karl/moz/dev/media/libvpx/vpx/./././vpx_codec.h:41:2: error: #error "Wrong vpx_codec.h"
 0:13.09  #error "Wrong vpx_codec.h"
 0:13.09   ^

 0:15.86 The following command failed to execute properly:
 0:15.87 c++ -o Unified_cpp_codecs_vp90.o -c -I/mnt/sda11/karl/obj/dist/system_wrappers -include /mnt/ssd1/karl/moz/dev/config/gcc_hidden.h -DDEBUG=1 -DTRACING=1 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DWEBRTC_MOZILLA_BUILD -DEXPAT_RELATIVE_PATH -DWEBRTC_POSIX -DWEBRTC_LINUX -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/mnt/ssd1/karl/moz/dev/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9 -I/mnt/sda11/karl/obj/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9 -I/mnt/ssd1/karl/moz/dev/media/webrtc/trunk -I/mnt/ssd1/karl/moz/dev/media/libvpx -I/mnt/ssd1/karl/moz/dev/media/webrtc/trunk/webrtc/common_video/interface -I/mnt/ssd1/karl/moz/dev/media/webrtc/trunk/webrtc/common_video/libyuv/include -I/mnt/sda11/karl/obj/ipc/ipdl/_ipdlheaders -I/mnt/ssd1/karl/moz/dev/ipc/chromium/src -I/mnt/ssd1/karl/moz/dev/ipc/glue -I/mnt/sda11/karl/obj/dist/include -fPIC -DMOZILLA_CLIENT -include /mnt/sda11/karl/obj/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_codecs_vp90.o.pp -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wtype-limits -Wunreachable-code -Wcast-align -Wno-invalid-offsetof -gsplit-dwarf -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -g -fno-omit-frame-pointer /mnt/sda11/karl/obj/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.cpp
Assignee: nobody → karlt
Blocks: 1237023
Component: Build Config → WebRTC: Audio/Video
Keywords: regression
to fix up --with-system-vpx after f442638a.
Attachment #8715650 - Flags: review?(mh+mozilla)
(In reply to Karl Tomlinson (ni?:karlt) from comment #3)
> Created attachment 8715650 [details] [diff] [review]
> correct vpx include path and vpx/svc_context.h visibilty
> 
> to fix up --with-system-vpx after f442638a.

The patch fixes the build for me. Thank you!
Status: UNCONFIRMED → NEW
Rank: 5
Ever confirmed: true
Priority: -- → P1
Attachment #8715650 - Flags: review?(mh+mozilla)
This version exports in-tree svc_context.h so that it can be found like other
vpx headers.
Attachment #8716108 - Flags: review?(mh+mozilla)
Attachment #8715650 - Attachment is obsolete: true
Attachment #8716108 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8716108 [details] [diff] [review]
correct vpx include path and vpx/svc_context.h visibilty

Approval Request Comment
[Feature/regressing bug #]: vp9 support for Webrtc (landed in late 46).  Patch just exports an additional header to our includes, and then uses normal build flags for includes instead of a relative path.

[User impact if declined]: inability to build aurora with system libvpx - linux distros care about this.

[Describe test coverage new/current, TreeHerder]: We don't test --with-system-anything in automation

[Risks and why]: extremely low risk - if it builds, we're good
[String/UUID change made/needed]:
Attachment #8716108 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4cc0e594e139
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8716108 [details] [diff] [review]
correct vpx include path and vpx/svc_context.h visibilty

Fix for some linux build issues, OK to uplift to aurora.
Attachment #8716108 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1248335
Regression, tracking retroactively :)
You need to log in before you can comment on or make changes to this bug.