Status
()
People
(Reporter: jchen, Assigned: jchen)
Tracking
Firefox Tracking Flags
(firefox47 fixed)
Details
Attachments
(1 attachment)
11.75 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Right now GeckoThread depends on the Gecko:Ready message sent by browser.js for changing the Gecko thread state to RUNNING. We should get rid of that dependency so we don't rely on having browser.js.
(Assignee) | ||
Comment 1•2 years ago
|
||
Created attachment 8712292 [details] [diff] [review] Control GeckoThread state entirely from C++ code (v1) Right now, we rely on browser.js sending Gecko:Ready, to set the GeckoThread state to RUNNING upon receiving Gecko:Ready. This patch gets rid of this dependency on browser.js and Gecko:Ready.
Attachment #8712292 -
Flags: review?(snorp)
Comment 2•2 years ago
|
||
Comment on attachment 8712292 [details] [diff] [review] Control GeckoThread state entirely from C++ code (v1) Review of attachment 8712292 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/android/nsAppShell.cpp @@ +329,5 @@ > } > } > removeObserver = true; > > + } else if (!strcmp(aTopic, "chrome-document-loaded")) { Cool, I didn't know about this event. Is the subject anything reasonable that we could use to figure out *which* chrome doc loaded?
Attachment #8712292 -
Flags: review?(snorp) → review+
(Assignee) | ||
Comment 3•2 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #2) > Comment on attachment 8712292 [details] [diff] [review] > Control GeckoThread state entirely from C++ code (v1) > > Review of attachment 8712292 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: widget/android/nsAppShell.cpp > @@ +329,5 @@ > > } > > } > > removeObserver = true; > > > > + } else if (!strcmp(aTopic, "chrome-document-loaded")) { > > Cool, I didn't know about this event. Is the subject anything reasonable > that we could use to figure out *which* chrome doc loaded? I think so. I'm pretty sure we can then get back the nsWindow/GeckoView if needed.
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a628353b83b8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•