1243069 - Get rid of Gecko:Ready dependency in GeckoThread

Status: RESOLVED FIXED

(Core :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now GeckoThread depends on the Gecko:Ready message sent by browser.js for changing the Gecko thread state to RUNNING. We should get rid of that dependency so we don't rely on having browser.js.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Control GeckoThread state entirely from C++ code (v1)

Right now, we rely on browser.js sending Gecko:Ready, to set the
GeckoThread state to RUNNING upon receiving Gecko:Ready. This patch
gets rid of this dependency on browser.js and Gecko:Ready.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8712292 [details] [diff] [review]
Control GeckoThread state entirely from C++ code (v1)

Review of attachment 8712292 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/nsAppShell.cpp
@@ +329,5 @@
>              }
>          }
>          removeObserver = true;
>  
> +    } else if (!strcmp(aTopic, "chrome-document-loaded")) {

Cool, I didn't know about this event. Is the subject anything reasonable that we could use to figure out *which* chrome doc loaded?

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #2)
> Comment on attachment 8712292 [details] [diff] [review]
> Control GeckoThread state entirely from C++ code (v1)
> 
> Review of attachment 8712292 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: widget/android/nsAppShell.cpp
> @@ +329,5 @@
> >              }
> >          }
> >          removeObserver = true;
> >  
> > +    } else if (!strcmp(aTopic, "chrome-document-loaded")) {
> 
> Cool, I didn't know about this event. Is the subject anything reasonable
> that we could use to figure out *which* chrome doc loaded?

I think so. I'm pretty sure we can then get back the nsWindow/GeckoView if needed.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a628353b83b8

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a628353b83b8