Closed
Bug 1243103
Opened 8 years ago
Closed 6 years ago
Intermittent browser_newtab_drag_drop_ext.js | grid status = 99p,0,1,2,3,4,5,7p,8p - Got ,0,1,2,3,4,5,7p,8p, expected 99p,0,1,2,3,4,5,7p,8p
Categories
(Firefox :: New Tab Page, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 60
People
(Reporter: KWierso, Assigned: enndeakin)
References
Details
(Keywords: intermittent-failure, leave-open, Whiteboard: [test disabled on Linux])
Attachments
(2 files)
24.69 KB,
patch
|
Details | Diff | Splinter Review | |
58 bytes,
text/x-review-board-request
|
jmaher
:
review+
|
Details |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 5•8 years ago
|
||
This has been failing intermittently since it was re-enabled by bug 1240014.
Blocks: 1240014
Flags: needinfo?(enndeakin)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 9•8 years ago
|
||
Logs suggest this is Linux only but happens with e10s on or off. The failure always happens in checkGrid, but doesn't always happen in the call to it.
Flags: needinfo?(enndeakin)
OS: Unspecified → Linux
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 17•8 years ago
|
||
I think I know what it happening here.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Assignee | ||
Comment 18•8 years ago
|
||
This patch does two things: 1. Adds a notificationsEnabled flag so that multiple notifications get ignored. This was causing tests to run after the wrong update call and have the wrong data. 2. Makes setPinnedLinks wait for an update before returning. The once concern is whether updateGrid should have error checking to reset notificationsEnabled if an error occurs.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 26•8 years ago
|
||
Any news here, Neil? This is still one of the top overall failures.
Flags: needinfo?(enndeakin)
Assignee | ||
Comment 27•8 years ago
|
||
I'll look at this again shortly. The patch here caused another test to fail.
Flags: needinfo?(enndeakin)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 30•8 years ago
|
||
I've spent way too much time on this and haven't found a working solution. Can you disable this test on Linux? Although maybe some OS10.6 failures are starting from the last week logs? Let's keep an eye on that too.
Flags: needinfo?(ryanvm)
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Reporter | ||
Comment 34•8 years ago
|
||
browser.ini got an extra line with just "skip-if =" which broke a bunch of tests. Dropped that line in https://hg.mozilla.org/integration/mozilla-inbound/rev/5806797af921
Comment 35•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7b05c8371114 https://hg.mozilla.org/mozilla-central/rev/5806797af921
Comment hidden (Intermittent Failures Robot) |
Comment 37•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5259f562df87
status-firefox48:
--- → disabled
status-firefox49:
--- → disabled
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•8 years ago
|
Assignee: enndeakin → nobody
Status: ASSIGNED → NEW
Comment 45•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69708/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69708/
Attachment #8778382 -
Flags: review?(jmaher)
Updated•8 years ago
|
Attachment #8778382 -
Flags: review?(jmaher) → review-
Comment 46•8 years ago
|
||
Comment on attachment 8778382 [details] Bug 1243103 - Move intermittent failure to clibboard suite; https://reviewboard.mozilla.org/r/69708/#review66774 I calculate a 1.5% failure rate on the existing hardware and a 8% failure rate on AWS- even if more data would change the percentages, that is still large enough to say this is an issue when running in a VM- lets try to figure it out or find a way to reduce this if possible before disabling the test.
Comment 47•8 years ago
|
||
Comment on attachment 8778382 [details] Bug 1243103 - Move intermittent failure to clibboard suite; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69708/diff/1-2/
Attachment #8778382 -
Flags: review- → review?(jmaher)
Comment 48•8 years ago
|
||
Comment on attachment 8778382 [details] Bug 1243103 - Move intermittent failure to clibboard suite; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69708/diff/2-3/
Attachment #8778382 -
Attachment description: Bug 1243103 - Disable intermittent failure on win debug; → Bug 1243103 - Move intermittent failure to clibboard suite;
Comment 49•8 years ago
|
||
Comment on attachment 8778382 [details] Bug 1243103 - Move intermittent failure to clibboard suite; https://reviewboard.mozilla.org/r/69708/#review66794 please add a comment indicating this is temporary until we can determine why this is more intermittent on a VM. Also we will need to run this on try as removing this test can cause problems (retrigger 20 times for the chunk that ends up running this browser/base/content/test directory), likewise adding this test to 'cl' (20 times here is good) can cause problems there. as a note, this will be on all platforms, that is OK, but it requires testing on all platforms prior to landing it!
Attachment #8778382 -
Flags: review?(jmaher) → review+
Comment 50•8 years ago
|
||
Comment on attachment 8778382 [details] Bug 1243103 - Move intermittent failure to clibboard suite; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69708/diff/3-4/
Comment hidden (Intermittent Failures Robot) |
Comment 52•8 years ago
|
||
(In reply to Joel Maher ( :jmaher ) from comment #49) > Comment on attachment 8778382 [details] > Bug 1243103 - Move intermittent failure to clibboard suite; > > https://reviewboard.mozilla.org/r/69708/#review66794 > > please add a comment indicating this is temporary until we can determine why > this is more intermittent on a VM. Also we will need to run this on try as > removing this test can cause problems (retrigger 20 times for the chunk that > ends up running this browser/base/content/test directory), likewise adding > this test to 'cl' (20 times here is good) can cause problems there. > > as a note, this will be on all platforms, that is OK, but it requires > testing on all platforms prior to landing it! Looks good on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=56c3e5f72f794d88a3007af50c32489fa202c3b2
Comment 53•8 years ago
|
||
Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d40036e732c8 Move intermittent failure to clibboard suite; r=jmaher
Comment 54•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d40036e732c8
Comment hidden (Intermittent Failures Robot) |
Comment 56•8 years ago
|
||
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment 57•7 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #54) > https://hg.mozilla.org/mozilla-central/rev/d40036e732c8 Oops, this tickled a bug in our test manifest parsing and as a result, this test has not been running - see bug 1333506. Once bug 1333506 lands and this test starts running again, if it passes consistently, we should consider moving other tests that fail in a similar way - bug 1243398 - to a subsuite.
Updated•7 years ago
|
Flags: needinfo?(gbrown)
Comment 58•7 years ago
|
||
I'll try the same "fix" in bug 1243398; there are other open bugs with a similar signature, but 1243398 is the only one currently failing.
Flags: needinfo?(gbrown)
Comment 59•6 years ago
|
||
Test was removed in bug 1433133 https://hg.mozilla.org/mozilla-central/rev/fc80dd3e4fae
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Depends on: 1433133
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Assignee: nobody → enndeakin
You need to log in
before you can comment on or make changes to this bug.
Description
•