1243117 - compiler warning: unsiged comparison with 0 is always false. ldap/c-sdk/libraries/libldap/sort.c

Status: RESOLVED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[ISHIKAWA, Chiaki]

Attachment: signed-vs-unsigned-issue-in-ldap.patch

I failed to copy the original compiler message but there are a couple of places where unsigned |count| is compared as in

  if (count < 0) 

and the compiler correctly warned this condition never succeeds.

Attached is the patch. I created a temporary signed value to receive the possible negative value and after the use in the if-expression
sets it to |count|.

TIA

Comment 1

[Kent James (:rkent)]

Comment on attachment 8712343 [details] [diff] [review]
signed-vs-unsigned-issue-in-ldap.patch

Review of attachment 8712343 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this slow review. LGTM.

Comment 2

[ISHIKAWA, Chiaki]

Attachment: Fixing a couple of compiler warnings. Carrying over r=rkent

Thank you for the review.

I updated the patch comment and added r=rkent at the end.
I will add checkin-needed keyword.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/8f470598a61d72601a618c63129079a700d9e21f
Bug 1243117 - compiler warning: unsiged comparison with 0 is alwayse false. ldap/c-sdk/libraries/libldap/sort.c r=rkent