1243182 - Enable eslint "space-infix-ops" rule for PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

The rule means spaces around infix operations are required.

In other words, things like these are prevented:
> var x=0;
> a+b

This helps enforce coding style.

Comment 1

[:Cykesiopka]

Attachment: bug1243182_enable-space-infix-ops_v1.patch

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8716151 [details] [diff] [review]
bug1243182_enable-space-infix-ops_v1.patch

Review of attachment 8716151 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: security/manager/pki/resources/content/certManager.js
@@ +193,5 @@
>  /**
>   * Returns true if nothing in the given cert tree is selected or if the
>   * selection includes a container. Returns false otherwise.
>   *
> + * @param {nsCertTree} certTree

I imagine we still want to call this an nsICertTree, since that's the interface, right?

::: security/manager/pki/resources/content/viewCertDetails.js
@@ +219,1 @@
>        AddUsage(usageList[i],verifyInfoBox);

Space after comma? (I guess that's another rule we'll have to enable...)

Comment 3

[:Cykesiopka]

Thanks for the review!

(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> I imagine we still want to call this an nsICertTree, since that's the
> interface, right?

On second thought, yeah, putting the interface here makes more sense.

> ::: security/manager/pki/resources/content/viewCertDetails.js
> @@ +219,1 @@
> >        AddUsage(usageList[i],verifyInfoBox);
> 
> Space after comma? (I guess that's another rule we'll have to enable...)

Yeah, another patch sitting in my queue. I filed Bug 1246365 for this.

Comment 4

[:Cykesiopka]

Attachment: bug1243182_enable-space-infix-ops_v2.patch

+ Address nsICertTree comment

Comment 5

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa205b7be666

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18b9f0924b4a

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/18b9f0924b4a