Enable eslint "space-infix-ops" rule for PSM

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The rule means spaces around infix operations are required.

In other words, things like these are prevented:
> var x=0;
> a+b

This helps enforce coding style.
(Assignee)

Updated

3 years ago
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8716151 [details] [diff] [review]
bug1243182_enable-space-infix-ops_v1.patch
Attachment #8716151 - Flags: review?(dkeeler)
Comment on attachment 8716151 [details] [diff] [review]
bug1243182_enable-space-infix-ops_v1.patch

Review of attachment 8716151 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: security/manager/pki/resources/content/certManager.js
@@ +193,5 @@
>  /**
>   * Returns true if nothing in the given cert tree is selected or if the
>   * selection includes a container. Returns false otherwise.
>   *
> + * @param {nsCertTree} certTree

I imagine we still want to call this an nsICertTree, since that's the interface, right?

::: security/manager/pki/resources/content/viewCertDetails.js
@@ +219,1 @@
>        AddUsage(usageList[i],verifyInfoBox);

Space after comma? (I guess that's another rule we'll have to enable...)
Attachment #8716151 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 3

3 years ago
Thanks for the review!

(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> I imagine we still want to call this an nsICertTree, since that's the
> interface, right?

On second thought, yeah, putting the interface here makes more sense.

> ::: security/manager/pki/resources/content/viewCertDetails.js
> @@ +219,1 @@
> >        AddUsage(usageList[i],verifyInfoBox);
> 
> Space after comma? (I guess that's another rule we'll have to enable...)

Yeah, another patch sitting in my queue. I filed Bug 1246365 for this.
(Assignee)

Comment 4

3 years ago
Created attachment 8716594 [details] [diff] [review]
bug1243182_enable-space-infix-ops_v2.patch

+ Address nsICertTree comment
Attachment #8716151 - Attachment is obsolete: true
Attachment #8716594 - Flags: review+

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/18b9f0924b4a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.