Closed
Bug 1243198
Opened 10 years ago
Closed 10 years ago
Use rvalue references for JS::ubi::ByFilename constructor
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
1.73 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
This change makes it a bit more clear that ByFilename is taking ownership of the
given arguments.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8712411 -
Flags: review?(jimb)
|
||
Updated•10 years ago
|
Attachment #8712411 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•10 years ago
|
||
That try push had test failures from the patch on top of it, here is a new one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=244e43dbfd1f
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
|
||
Comment 5•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•