Closed Bug 1243243 Opened 6 years ago Closed 6 years ago

Use standard license boilerplate in debugger js files


(DevTools :: Debugger, defect)

Not set


(firefox47 fixed)

Firefox 47
Tracking Status
firefox47 --- fixed


(Reporter: linclark, Assigned: linclark)




(1 file, 1 obsolete file)

See Bug 1241947
Assignee: nobody → lclark
Blocks: 1241947
Attached patch Bug1243243.patch (obsolete) — Splinter Review
This patch updates the license block in the debugger js files.

I skipped the code_* files because line numbers from those were hardcoded in tests.

Here's a try push that just runs the devtools tests on Linux. Let me know if I should run a full one.
Attachment #8712861 - Flags: review?(jlong)
Attached patch Bug1243243.patchSplinter Review
:jryans pointed out that tests should be public domain, so updated the patch.

new try push:
Attachment #8712861 - Attachment is obsolete: true
Attachment #8712861 - Flags: review?(jlong)
Attachment #8712904 - Flags: review?(jlong)
Sorry, I thought we were removing the emacs/vim mode lines? Nobody said they actually used them and several people said they'd be fine if they were removed.
What I said in the meeting is "We can have that fight later". They are currently in the header because Mozilla Code Standard says they should be there.

My goal is to make everything consistent. Once it's consistent, it will be a lot easier to change what our default is.
Ok. This looks like more than half the files, and if so maybe the initial consistency should be just removing it (majority wins) :) But this is fine with me.
Attachment #8712904 - Flags: review?(jlong) → review+
Yeah, I did notice that debugger was more internally consistent than others. The style seems to vary between components, with each component having its own 2 or 3 styles. In webconsole, there were a lot of files that just had the vim line, but not the emacs line. 

Thanks for the review :)
Keywords: checkin-needed
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.