Use standard license boilerplate in debugger js files

RESOLVED FIXED in Firefox 47

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: linclark, Assigned: linclark)

Tracking

Trunk
Firefox 47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
See Bug 1241947
(Assignee)

Updated

2 years ago
Assignee: nobody → lclark
Blocks: 1241947
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8712861 [details] [diff] [review]
Bug1243243.patch

This patch updates the license block in the debugger js files.

I skipped the code_* files because line numbers from those were hardcoded in tests.

Here's a try push that just runs the devtools tests on Linux. Let me know if I should run a full one.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b6f973ea735&selectedJob=16009487
Attachment #8712861 - Flags: review?(jlong)
(Assignee)

Comment 2

2 years ago
Created attachment 8712904 [details] [diff] [review]
Bug1243243.patch

:jryans pointed out that tests should be public domain, so updated the patch.

new try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=65e18a5eb7dc
Attachment #8712861 - Attachment is obsolete: true
Attachment #8712861 - Flags: review?(jlong)
Attachment #8712904 - Flags: review?(jlong)
Sorry, I thought we were removing the emacs/vim mode lines? Nobody said they actually used them and several people said they'd be fine if they were removed.
(Assignee)

Comment 4

2 years ago
What I said in the meeting is "We can have that fight later". They are currently in the header because Mozilla Code Standard says they should be there.

My goal is to make everything consistent. Once it's consistent, it will be a lot easier to change what our default is.
Ok. This looks like more than half the files, and if so maybe the initial consistency should be just removing it (majority wins) :) But this is fine with me.
Attachment #8712904 - Flags: review?(jlong) → review+
(Assignee)

Comment 6

2 years ago
Yeah, I did notice that debugger was more internally consistent than others. The style seems to vary between components, with each component having its own 2 or 3 styles. In webconsole, there were a lot of files that just had the vim line, but not the emacs line. 

Thanks for the review :)
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/440a72b7b690
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.