1243289 - UITour: Remove never used UrlbarCapture code

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Matthew N. [:MattN]]

It's not really getting in the way other than taking up space in the library and in my editor when looking at UITour.jsm. It's not even tested so it's not really wasting test resources but the fact that it's not tested and was never used on a production tour means it may not even work anymore. I don't see us using this anytime in the future as I doubt people who plan tours even remember it exists.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1243289 - UITour: Remove never used UrlbarCapture code. r=Gijs

Review commit: https://reviewboard.mozilla.org/r/32581/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32581/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8712554 [details]
MozReview Request: Bug 1243289 - UITour: Remove never used UrlbarCapture code. r=Gijs

https://reviewboard.mozilla.org/r/32581/#review29315

r=me but please get an f+ from someone on the tour team to ensure we're not removing something that they need/use. I couldn't find something on github but I'm trying to be more cautious about involving other stakeholders explicitly after some of the recent issues with about:home and about:newtab.

Comment 3

[Alex Gibson [:agibson]]

I can't answer for other properties such as about:home or about:newtab, but I can confirm we've never used this functionality on www.mozilla.org.

I seem to remember UrlbarCapture was added to Firefox in the pre-Australis prototyping stage (the idea was some form of easter-egg if you typed something specific in the URL bar), but it was never used in production for any /firstrun or /whatsnew UITour. It can safely be removed as far as www.mozilla.org goes :)

Comment 4

[Matthew N. [:MattN]]

(In reply to :Gijs Kruitbosch from comment #2)
> r=me but please get an f+ from someone on the tour team to ensure we're not
> removing something that they need/use.

Thanks. I had CC'd Alex and knew he would reply :)

Alex is right that it is from the initial UITour implementation and I've never heard of it being used as it was an easter-egg like feature.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/60a507faca0d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60a507faca0d