1243310 - Cert error page 'advanced' section is misaligned

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: after fix vs before fix.png

47.0a1 (2016-01-26) Win 7

STR:
1. Open https://wrong.host.badssl.com/
2. Click the "Advanced" button

Actual results:
'advanced' section is misaligned

Expected results:
'advanced' section should be aligned correctly

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Fix misaligned advanced panel in about:certerror

Sorry I missed this in my review of bug 1207130. I assume you added the position:absolute bit for consistency with about:neterror, but neither is needed any longer.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8712636 [details] [diff] [review]
Fix misaligned advanced panel in about:certerror

Review of attachment 8712636 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, it was added to prevent the page from jumping around. But looks like that doesn't happen anymore.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0b375bcf144a

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b375bcf144a

Comment 5

[Paul Silaghi, QA [:pauly]]

Could this patch affect the UI for https://rc4.badssl.com/ too?
I see an auto-centering behavior on https://rc4.badssl.com/ on pressing the "Advanced" button, which didn't happen before. Also this doesn't happen on https://wrong.host.badssl.com/.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Indeed, I missed it in my testing. I'll try to get it fixed.

Comment 7

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 47.0a1 (2016-02-02) Win 7, Ubuntu 14.04, OS X 10.10.5.
Let me know if you want a new bug filed for the comment 5.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Paul Silaghi, QA [:pauly] from comment #7)
> Let me know if you want a new bug filed for the comment 5.

That would be best, thank you.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8712636 [details] [diff] [review]
Fix misaligned advanced panel in about:certerror

Approval Request Comment
[Feature/regressing bug #]: bug 1207130
[User impact if declined]: a visual glitch will appear in some of our error pages
[Describe test coverage new/current, TreeHerder]: manual
[Risks and why]: insignificant risk, the change is CSS-only, tiny and limited to the error pages in question
[String/UUID change made/needed]: none

Comment 10

[Paul Silaghi, QA [:pauly]]

(In reply to Panos Astithas [:past] from comment #8)
> (In reply to Paul Silaghi, QA [:pauly] from comment #7)
> > Let me know if you want a new bug filed for the comment 5.
> That would be best, thank you.
Which one is the correct behavior? https://rc4.badssl.com/ or https://wrong.host.badssl.com/ ?

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

The behavior in https://wrong.host.badssl.com/ is the correct one. The page contents shouldn't be moving when the button is clicked.

Comment 12

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Recent regression (from 46), tracking.

Comment 13

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8712636 [details] [diff] [review]
Fix misaligned advanced panel in about:certerror

Minor css fix for recent regression. OK to uplift.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6426f9752a17

Comment 15

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Yes

Actual Results: 
As expected