1243313 - Do not localize "Global" scope type in debugger for consistency

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect)

Description

[Théo Chevalier]

Attachment: Screenshot, French

We're localizing "Global" in "Global scope" header with this string: 

https://transvision.mozfr.org/?sourcelocale=en-US&locale=fr&repo=aurora&search_type=entities&recherche=devtools/client/debugger.properties:globalScopeLabel

But since we're not localizing other scope types as discussed here [1], we should not localize Global either for consistency. Flod, any reason I would have missed for not doing that?

Thanks to Julien for spotting this issue :) Fixed French manually here [2], but I guess it would make sense to remove this string completely for other locales.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=755346#c39
[2] http://hg.mozilla.org/l10n-central/fr/rev/67082fdacb90#l1.24

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Théo Chevalier [:tchevalier] from comment #0)
> But since we're not localizing other scope types as discussed here [1], we
> should not localize Global either for consistency. Flod, any reason I would
> have missed for not doing that?

One possible reason might be the case, but I think it might make more sense to hard-code it.

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

In that case, https://transvision.mozfr.org/?sourcelocale=en-US&repo=aurora&search_type=entities&recherche=devtools/client/debugger.properties:scopeLabel should also be not localizeable, so we do not have partly localized and not localized strings.

Comment 4

[Théo Chevalier]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ] from comment #2)
> In that case,
> https://transvision.mozfr.org/?sourcelocale=en-
> US&repo=aurora&search_type=entities&recherche=devtools/client/debugger.
> properties:scopeLabel should also be not localizeable, so we do not have
> partly localized and not localized strings.

I would leave it localized, because you can turn it into a less awkward translation like "Scope: %S". 
That's what we choose for French: localized label, English value
https://transvision.mozfr.org/?sourcelocale=en-US&locale=fr&repo=aurora&search_type=entities&recherche=devtools/client/debugger.properties:scopeLabel

Maybe that would be helpful mentioning this possibility in a localization note.

Comment 5

[Rimas Kudelis [use needinfo to ping]]

I believe that all of these strings actually SHOULD be localizable. For example, "function" is both a non-localizable lexical construct, and a (quite localizable) name of a thing it refers to. In case of "block" it's even more obvious that in various languages it can be called differently.

I think it should be left up to the localizers to decide which way to go here. I'd much rather see "Funkcijos kintamieji" and "Bloko kintamieji" than "Function kintamieji" and "Block kintamieji" in my language.

Comment 6

[Rimas Kudelis [use needinfo to ping]]

While at that, I believe the string "(anonymous)" should also be localizable.

Comment 7

[Mantaroh Yoshinaga[:mantaroh]]

Modified Whiteboard 'good-first-bug' to 'good first bug'.
See https://wiki.mozilla.org/Good_first_bug

Comment 8

[Patrick Brosset <:pbro>]

[good first bug] whiteboard -> keyword mass change

Comment 9

[Brian Farr]

Was looking at this because it has the good-first-bug keyword, but it seems like it might not be applicable anymore. 

> Examine, modify, and watch variables
> 
> This feature isn't yet supported in the new debugger. If you need to use it, you can, for now, switch back to the old debugger by visiting about:config and setting the "devtools.debugger.new-debugger-frontend" preference to false.

From the documentation at https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Examine,_modify,_and_watch_variables#wikiArticle

Should this be closed? Or just looked at again when or if this feature is implemented in the new debugger front end?

Comment 10

[Brian Grinstead [:bgrins]]

(In reply to Brian Farr from comment #9)
> Was looking at this because it has the good-first-bug keyword, but it seems
> like it might not be applicable anymore. 
> 
> > Examine, modify, and watch variables
> > 
> > This feature isn't yet supported in the new debugger. If you need to use it, you can, for now, switch back to the old debugger by visiting about:config and setting the "devtools.debugger.new-debugger-frontend" preference to false.
> 
> From the documentation at
> https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Examine,
> _modify,_and_watch_variables#wikiArticle
> 
> Should this be closed? Or just looked at again when or if this feature is
> implemented in the new debugger front end?

Jason, should we close this bug or does this affect the new frontend as well?

Comment 11

[Jason Laster [:jlast]]

We can close it