Moz2d's new PushLayer/PopLayer API interacts badly with DrawTargetTiled

ASSIGNED
Assigned to

Status

()

Core
Graphics
P3
normal
ASSIGNED
2 years ago
9 months ago

People

(Reporter: nical, Assigned: bas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8712613 [details]
screenshot of theverge.com with the glitches

It is probably expected since I think PushLayer isn't implemented for all backends yet. enabling DrawTargetTiled and PushLayer/PopLayer gives some weird semi-transaprent balck boxes over content. Some pages reproduce the issue a lot, like theverge.com.
(Reporter)

Updated

2 years ago
Whiteboard: [gfx-noted]
(Assignee)

Updated

2 years ago
Assignee: nobody → bas
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
The cause here is that if we're not even pushing their clips to tiles that are completely clipped out, but we're also not pushing drawing commands, if we then proceed to push and pop opaque layers to them, they will be drawn back black with a certain opacity. I have a fix.
(Assignee)

Comment 2

2 years ago
Created attachment 8718668 [details]
MozReview Request: Bug 1243336: Don't push layers to tiles that are completely clipped out. r=jrmuizel

Review commit: https://reviewboard.mozilla.org/r/34683/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34683/
Attachment #8718668 - Flags: review?(jmuizelaar)
Comment on attachment 8718668 [details]
MozReview Request: Bug 1243336: Don't push layers to tiles that are completely clipped out. r=jrmuizel

https://reviewboard.mozilla.org/r/34683/#review32745
Attachment #8718668 - Flags: review?(jmuizelaar) → review+
Any plans to land this, Bas?
Flags: needinfo?(bas)
(Assignee)

Comment 5

a year ago
(In reply to Jonathan Watt [:jwatt] from comment #4)
> Any plans to land this, Bas?

We probably should? Does it still pass tests and stuff? Do we still need it though? If we had this bug I'd expect more people to be complaining about it now that DTTiled and Push/PopLayer are all implemented.
Flags: needinfo?(bas)
Note Push/PopLayer are not turned on on Mac/Android (bug 1322729). As for your other questions, I don't know. I just noticed this hadn't landed in passing.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.