1243352 - [Static Analysis][Uninitialized scalar field] In function ProxyHandlerInfo from HandlerServiceParent.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that variable mPrefAction is not initialized in the constructor. 
In fact there is no place where mPrefAction is initialized, just used in function:

>>NS_IMETHODIMP ProxyHandlerInfo::GetPreferredAction(nsHandlerInfoAction *aPreferredAction)
>>{
>>  *aPreferredAction = mPrefAction;
>>  return NS_OK;
>>}

I think it should be initialized in this function: 
>> NS_IMETHODIMP ProxyHandlerInfo::SetPreferredAction(nsHandlerInfoAction aPreferredAction)

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

Review commit: https://reviewboard.mozilla.org/r/32597/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32597/

Comment 2

[Andi [:andi]]

Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32597/diff/1-2/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

https://reviewboard.mozilla.org/r/32597/#review29327

Please ask the author or reviewer of this code for review.  I'd redirect it, but mozreview won't let me do that, so...

Comment 4

[Andi [:andi]]

Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32597/diff/2-3/

Comment 5

[Andi [:andi]]

https://reviewboard.mozilla.org/r/32597/#review29327

Thx, redirecting to to Brad

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

https://reviewboard.mozilla.org/r/32597/#review29409

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/74c0f6e5e749

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74c0f6e5e749