Closed Bug 1243352 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized scalar field] In function ProxyHandlerInfo from HandlerServiceParent.cpp

Categories

(Core :: DOM: Navigation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1346311 )

Attachments

(1 file)

The Static Analysis tool Coverity added that variable mPrefAction is not initialized in the constructor. 
In fact there is no place where mPrefAction is initialized, just used in function:

>>NS_IMETHODIMP ProxyHandlerInfo::GetPreferredAction(nsHandlerInfoAction *aPreferredAction)
>>{
>>  *aPreferredAction = mPrefAction;
>>  return NS_OK;
>>}

I think it should be initialized in this function: 
>> NS_IMETHODIMP ProxyHandlerInfo::SetPreferredAction(nsHandlerInfoAction aPreferredAction)
Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32597/diff/1-2/
Attachment #8712645 - Attachment description: MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?bzbarsky → MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?bz
Attachment #8712645 - Flags: review?(bzbarsky)
Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

https://reviewboard.mozilla.org/r/32597/#review29327

Please ask the author or reviewer of this code for review.  I'd redirect it, but mozreview won't let me do that, so...
Attachment #8712645 - Flags: review?(bzbarsky)
Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32597/diff/2-3/
Attachment #8712645 - Attachment description: MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?bz → MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey
Attachment #8712645 - Flags: review?(blassey.bugs)
Comment on attachment 8712645 [details]
MozReview Request: Bug 1243352 - attribute a value for ProxyHandlerInfo::mPrefAction in ProxyHandlerInfo::SetPreferredAction. r?blassey

https://reviewboard.mozilla.org/r/32597/#review29409
Keywords: checkin-needed
Attachment #8712645 - Flags: review?(blassey.bugs)
https://hg.mozilla.org/mozilla-central/rev/74c0f6e5e749
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.