Closed Bug 1243353 Opened 6 years ago Closed 6 years ago

Make the "Report errors like this" option keyboard accessible on the cert error page

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 47
Iteration:
47.1 - Feb 8
Tracking Status
firefox46 --- verified
firefox47 --- verified

People

(Reporter: pauly, Assigned: Gijs)

References

()

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

47.0a1 (2016-01-26) Win 7
Now I'm unable to use the keyboard for checking the "Report errors like this etc" option on https://wrong.host.badssl.com/. We should correct that.
Priority: -- → P3
Whiteboard: [fxsearch]
Flags: qe-verify?
Whiteboard: [fxsearch] → [fxprivacy]
Component: General → Keyboard Navigation
Flags: qe-verify? → qe-verify+
See Also: → 1136645
Seems like bug 1136645 got addressed in bug 1165973, but left out Linux, so now it has no focus styling for checkboxes, radio buttons and menulists.

All of the styling is broken for HTML input type="checkbox" because we hide the actual checkbox.
Component: Keyboard Navigation → Theme
See Also: 11366451165973
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Note that the patch here uses a focus box around the checkbox instead of the label. Because of the HTML structure, it's not possible to do one only around the label (which is what we do for XUL checkboxes). This is unfortunate, but not a showstopper, I believe.
Why not just change the HTML structure?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> Why not just change the HTML structure?

Because it's currently:

<input type="checkbox"/>
<label>Text to label checkbox</label>

and while we could add a container inside the label (like a span) to take care of this issue, that feels like not great markup, either. Plus we would need to update all the in-content pages that use checkboxes like this (not just about:certerror and about:neterror, but also including about:tabcrashed, about:debugging, and maybe about:networking if/when that uses in-content theming, and we'd need to remember to use a similar technique for any other future in-content HTML checkboxes...).
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Gijs Kruitbosch from comment #3)
> Note that the patch here uses a focus box around the checkbox instead of the
> label. Because of the HTML structure, it's not possible to do one only
> around the label (which is what we do for XUL checkboxes). This is
> unfortunate, but not a showstopper, I believe.

Also, this is only a compat issue with the XUL ones for Windows and Linux. On OS X the patch already produces the expected behaviour.
(In reply to :Gijs Kruitbosch from comment #6)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Note that the patch here uses a focus box around the checkbox instead of the
> > label. Because of the HTML structure, it's not possible to do one only
> > around the label (which is what we do for XUL checkboxes). This is
> > unfortunate, but not a showstopper, I believe.
> 
> Also, this is only a compat issue with the XUL ones for Windows and Linux.
> On OS X the patch already produces the expected behaviour.

... that is, there we expect the focusring to be around the checkbox, not the label, and that is what happens. I believe the distinction is due to platform conventions.
See Also: → 1241433
Comment on attachment 8714483 [details]
MozReview Request: Bug 1243353 - allow HTML in-content checkboxes to have focus and style them appropriately, r?jaws

https://reviewboard.mozilla.org/r/33105/#review30339

LGTM
Attachment #8714483 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/4b0f903bdb28
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Iteration: --- → 47.1 - Feb 8
Priority: P3 → P1
47.0a1 (2016-02-08) Win 7
Note that I can only check the option using the SPACE key, but not the ENTER key.
(In reply to Paul Silaghi, QA [:pauly] from comment #11)
> 47.0a1 (2016-02-08) Win 7
> Note that I can only check the option using the SPACE key, but not the ENTER
> key.

This is normal behaviour for checkboxes, I believe. If we want to change that it would be a separate, orthogonal bug.

Needinfo for myself to uplift this to aurora with a=css-image-only later.
Status: RESOLVED → VERIFIED
Flags: needinfo?(gijskruitbosch+bugs)
Blocks: 1216897
Verified fixed Fx 46.0a2 (2016-02-12) Win 7
Depends on: 1262772
Duplicate of this bug: 1194530
You need to log in before you can comment on or make changes to this bug.