1243401 - [Static Analysis][Uninitialized pointer field] In function MIRGenerator::MIRGenerator(..)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that variables fun_ and nslots_ are not initialized. Since they are not used in the code we should remove them.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1243401 - removed unused variables fun_ and nslots_ from MIRGenerator. r?jorendorff

Review commit: https://reviewboard.mozilla.org/r/32629/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32629/

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8712702 [details]
MozReview Request: Bug 1243401 - removed unused variables fun_ and nslots_ from MIRGenerator. r?jorendorff

https://reviewboard.mozilla.org/r/32629/#review29353

Comment 3

[Nicolas B. Pierron [:nbp]]

Note, the reasons these fields are unused is because they moved to the CompileInfo structure.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 8712702 [details]
MozReview Request: Bug 1243401 - removed unused variables fun_ and nslots_ from MIRGenerator. r?jorendorff

https://reviewboard.mozilla.org/r/32629/#review29405

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7015ed506bc3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7015ed506bc3