1243445 - Pasting an invalid URL breaks the Downloads View in the Library (downloads are displayed as history items)

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160126030244
STR:
1. Copy "http://example.org/" (without quotes) in clipboard
2. Open  downloads panel (Ctrl+J), Paste the string copied in Step 1 (Ctrl+V) to start download
3. Copy "example.org" (without quotes) in clipboard
4. Open  downloads panel (Ctrl+J), Paste the string copied in Step 3 (Ctrl+V)
5. Close downloads panel (Ctrl+W), then open it again (Ctrl+J)

Result:       Downloads are displayed as history/bookmark items.
Expectations: Downloads should always be displayed the same way.

This was triggered by bug 945707 (presumably). Regression range:
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73eefb421e2a&tochange=735a648bca0d

Screenshot
> https://dl.dropboxusercontent.com/s/s1xu2krf3g9ht37/screenshot%201%20-%20Items%20in%20downloads%20panel%20are%20displayed%20as%20history%20items.png?dl=0

Comment 1

[arni2033]

>>>   My Info:   Win7_64, Nightly 51, 32bit, ID 20160805030444 (2016-08-05)
Reproducible.
Actually, I just used this bug to easily access saved urls and SORT them.
Sorting doesn't work by default, but it's another bug.

Comment 2

[Gerry Chang [:gchang]]

Hi :Paolo,
This bug is a regression and is assigned to nobody and we need someone to work on this. Since it seems that you are involved in this, could you help to take a look at this?

Comment 3

[:Paolo Amadini]

Attachment: Bug 1243445 - Pasting an invalid URL breaks the Downloads View in the Library.

Review commit: https://reviewboard.mozilla.org/r/73316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73316/

Comment 4

[:Paolo Amadini]

Marco is not back yet, so asking Jared for review. The actual fix is checking that the command is enabled to prevent pasting a wrong URL in the first place, but I also added error handling so that if an invalid source URL is created somehow, the view does not break entirely.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8783529 [details]
Bug 1243445 - Pasting an invalid URL breaks the Downloads View in the Library.

https://reviewboard.mozilla.org/r/73316/#review71140

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c2208aa03218
Pasting an invalid URL breaks the Downloads View in the Library. r=jaws

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2208aa03218

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Please request uplift to 50.

Comment 9

[Sayed [:LiquidO2]]

I have reproduced this bug with Nightly 47.0a1(2016-01-27) on Elementary OS 64bit

This bug's fix is now verified in latest Nightly 51.0a1

Build ID 	20160901030202
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160831]

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

Please request uplift approval for FF 50.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8783529 [details]
Bug 1243445 - Pasting an invalid URL breaks the Downloads View in the Library.

Approval Request Comment
[Feature/regressing bug #]: bug 945707
[User impact if declined]: pasting an invalid URL in to downloads view of the library causes the downloads items to appear as bookmarks/history
[Describe test coverage new/current, TreeHerder]: manual testing, verified on nightly, landed on m-c for a couple weeks now
[Risks and why]: none expected
[String/UUID change made/needed]: none

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8783529 [details]
Bug 1243445 - Pasting an invalid URL breaks the Downloads View in the Library.

Recent regression, fix was verified in Nightly, Aurora50+

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d7b3e0350c05

Comment 15

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I managed to reproduce this issue on 50.0a1 (2016-08-01). It is verified fixed on 50.0b2 build1 (20160926162149), using Windows 10 x64, Ubuntu 14.04 x86 and Mac OS X 10.11.6.