If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsNntpUrl.cpp build fix for solaris/native compilers

VERIFIED FIXED in M10

Status

MailNews Core
Backend
P3
normal
VERIFIED FIXED
18 years ago
9 years ago

People

(Reporter: tor, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Trunk
Sun
Solaris

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
Your recent change to nsNntpUrl.cpp (1.35) broke the solaris/native
build.  The solaris compiler is strict, requiring this patch to compile:

Index: nsNntpUrl.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/news/src/nsNntpUrl.cpp,v
retrieving revision 1.35
diff -u -r1.35 nsNntpUrl.cpp
--- nsNntpUrl.cpp       1999/08/24 22:39:40     1.35
+++ nsNntpUrl.cpp       1999/08/25 01:35:09
@@ -288,7 +288,7 @@

     nsCString newsgroupURI(kNewsMessageRootURI);
     newsgroupURI.Append("/");
-    if (userName || (userName != "")) {
+    if (userName || (userName != (const char *)"")) {
        newsgroupURI.Append(userName);
        newsgroupURI.Append("@");
     }
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Target Milestone: M10
marking m10.

thanks for the patch.

I've checked the fix in.

marking fixed.

Updated

18 years ago
QA Contact: lchiang → tor

Comment 2

18 years ago
tor@cs.brown.edu - I've changed the QA Contact to you.  Can you verify this once
it's checked in?  Thanks
(Reporter)

Updated

18 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 3

18 years ago
Verified on a 8/25 CVS pull.
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.