Closed
Bug 1243508
Opened 8 years ago
Closed 8 years ago
Theme tries to access non-existent file itemEnabledFader.png
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.9
People
(Reporter: ssitter, Assigned: Paenglab)
References
Details
Attachments
(1 file)
12.77 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora-
Fallen
:
approval-calendar-beta-
|
Details | Diff | Splinter Review |
Noticed the following output in debug build of Thunderbird 47.0a1: Chrome file doesn't exist: d:\dev\comm-central\src\obj-i686-pc-mingw32\dist\bin\chrome\toolkit\skin\classic\mozapps\extensions\itemEnabledFader.png I found Bug 662744 about similar issue in Firefox. Its solution was to remove the obsolete rules. According to https://mxr.mozilla.org/comm-central/search?string=itemEnabledFader.png the file is loaded in various location. Maybe the obsolete rules can be removed from Lightning too.
Assignee | ||
Comment 1•8 years ago
|
||
I use this bug only for the calendar changes. For IM/chat I'm using bug 1243831.
Assignee | ||
Comment 2•8 years ago
|
||
I only remove the references to this file. The files where already removed in esr 10. So we are since long time familiar without this gradient. While checking I saw we had a not used common calendar-invitations-dialog.css with the same content like the platform files, except one small addition on OS X. I decided to use this common file like we use already on other files. Only one question, what do I need to see this calendar-invitations-dialog?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8713281 -
Flags: review?(philipp)
Assignee | ||
Updated•8 years ago
|
Attachment #8713281 -
Flags: approval-calendar-beta?(philipp)
Attachment #8713281 -
Flags: approval-calendar-aurora?(philipp)
Comment 3•8 years ago
|
||
Comment on attachment 8713281 [details] [diff] [review] NoitemEnabledFader.png.patch Review of attachment 8713281 [details] [diff] [review]: ----------------------------------------------------------------- So this is only a message in the debug build, nothing user-visible? In that case I don't think there is a need for aurora/beta approval and we can just let this ride the trains. If otherwise please re-request.
Attachment #8713281 -
Flags: review?(philipp)
Attachment #8713281 -
Flags: review+
Attachment #8713281 -
Flags: approval-calendar-beta?(philipp)
Attachment #8713281 -
Flags: approval-calendar-beta-
Attachment #8713281 -
Flags: approval-calendar-aurora?(philipp)
Attachment #8713281 -
Flags: approval-calendar-aurora-
Assignee | ||
Comment 4•8 years ago
|
||
http://hg.mozilla.org/comm-central/rev/f415ab31364d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.9
You need to log in
before you can comment on or make changes to this bug.
Description
•