[e10s] Enable test_blob_file_backed.html with e10s

RESOLVED FIXED in Firefox 47

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox47 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
This test creates a new file, which is at least the first reason it fails. One wrinkle here is that it is actually done in a file that doubles as an xpcshell unit test. Probably the way to fix this is to implement SpecialPowers.createFiles() in dom/indexedDB/test/unit/xpcshell-head-parent-process.js (where the SpecialPowers.createDOMFile() the test current uses is defined), convert the test, then delete SpecialPowers.createFiles(), which has no other users.

Updated

2 years ago
Blocks: 984139
tracking-e10s: --- → +

Comment 1

2 years ago
Yeah, this seems about right.
(Assignee)

Updated

2 years ago
Depends on: 1248097
(Assignee)

Comment 2

2 years ago
Created attachment 8720581 [details] [diff] [review]
part 1 - Delete trailing whitespace in xpcshell-head-parent-process.js.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aa2a7e25c6a
Attachment #8720581 - Flags: review?(khuey)
(Assignee)

Comment 3

2 years ago
Created attachment 8720582 [details] [diff] [review]
part 2 - Change file permissions to match SpecialPowers.createFiles.

I don't think that this matters, but I split it into a separate change set to avoid hiding it.
Attachment #8720582 - Flags: review?(khuey)
(Assignee)

Comment 4

2 years ago
Created attachment 8720583 [details] [diff] [review]
part 3 - Make test_blob_file_backed.js use SpecialPowers.createFiles().

This method is e10s-compatible. It is async, so it requires rejiggering the test a little. This also requires fixing up a shim version for xpcshell tests. Finally, this test is the only user of SpecialPowers.createDOMFiles, so I removed it.
Attachment #8720583 - Flags: review?(khuey)
Comment on attachment 8720582 [details] [diff] [review]
part 2 - Change file permissions to match SpecialPowers.createFiles.

Review of attachment 8720582 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/unit/test_blob_file_backed.js
@@ -11,5 @@
>  {
>    const fileIOFlags = 0x02 | // PR_WRONLY
>                        0x08 | // PR_CREATEFILE
>                        0x20;  // PR_TRUNCATE
> -  const filePerms = 0664;

664 is an odd choice ...
Attachment #8720582 - Flags: review?(khuey) → review+
(Assignee)

Comment 7

2 years ago
Thanks for the reviews. I updated the 0 octal constants to 0o because somebody went through and fixed those up recently.

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2d2a4d6a97d7
https://hg.mozilla.org/mozilla-central/rev/3c13b0cab347
https://hg.mozilla.org/mozilla-central/rev/fe5831958b30
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.