Add session/usage data to telemetry pings

RESOLVED FIXED in Firefox 49

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

unspecified
Firefox 49
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 2 obsolete attachments)

From the mobile telemetry documentation:

  "usage": [<pos integer>, <pos integer>],
    // array of total usage time in seconds since last ping and
    // foreground session count, e.g.: [156, 2]

Since we're adding counts since last ping, we need bug 1243585 to land first.
Duplicate of this bug: 1260735
Blocks: 1251636
No longer blocks: 1220177
No longer depends on: 1251636
As we discussed in today's meeting: we should break this into two fields instead of one:
* session time in seconds (aggregate)
* number of sessions

We'll see how that feels and change it if necessary.
Summary: (telemetry v4) Add session/usage data to telemetry pings → Add session/usage data to telemetry pings
Assignee: nobody → michael.l.comella
(In reply to Michael Comella (:mcomella) from comment #2)
> As we discussed in today's meeting: we should break this into two fields
> instead of one:
> * session time in seconds (aggregate)
> * number of sessions

Georg, do you have opinions on field names? I propose:
 * sessionCount
 * sessionDuration
Flags: needinfo?(gfritzsche)
Georg, also, for the initial ping, the first measurements will be 0 & 0 – would we prefer to omit the field or leave it as 0 & 0?
Created attachment 8753581 [details]
MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53360/
Attachment #8753581 - Flags: review?(ahunt)
Attachment #8753582 - Flags: review?(ahunt)
Attachment #8753583 - Flags: review?(ahunt)
Created attachment 8753582 [details]
MozReview Request: Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53362/
Created attachment 8753583 [details]
MozReview Request: Bug 1243595 - Add session measurement hooks for record and retrieval. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53364/
(In reply to Michael Comella (:mcomella) from comment #4)
> Georg, also, for the initial ping, the first measurements will be 0 & 0 –
> would we prefer to omit the field or leave it as 0 & 0?

For simplicity, I'd vote just leave it 0, 0.
Landing on bug 1273686 for convenience.
Depends on: 1273686
Comment on attachment 8753581 [details]
MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53360/diff/1-2/
Comment on attachment 8753582 [details]
MozReview Request: Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53362/diff/1-2/
Comment on attachment 8753583 [details]
MozReview Request: Bug 1243595 - Add session measurement hooks for record and retrieval. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53364/diff/1-2/
Comment on attachment 8753581 [details]
MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53360/diff/2-3/
Attachment #8753581 - Attachment description: MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt → MozReview Request: Bug 1243595 - Only log telemetry in release builds. r=grisha
Attachment #8753581 - Flags: review?(ahunt) → review?(gkruglov)
Attachment #8753582 - Attachment is obsolete: true
Attachment #8753582 - Flags: review?(ahunt)
Attachment #8753583 - Attachment is obsolete: true
Attachment #8753583 - Flags: review?(ahunt)
Created attachment 8754104 [details]
MozReview Request: Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53722/
Attachment #8753581 - Attachment description: MozReview Request: Bug 1243595 - Only log telemetry in release builds. r=grisha → MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt
Attachment #8754104 - Flags: review?(ahunt)
Attachment #8754105 - Flags: review?(ahunt)
Attachment #8753581 - Flags: review?(gkruglov) → review?(ahunt)
Created attachment 8754105 [details]
MozReview Request: Bug 1243595 - Add session measurement hooks for record and retrieval. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53724/
Comment on attachment 8753581 [details]
MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53360/diff/3-4/
(In reply to Michael Comella (:mcomella) from comment #3)
> (In reply to Michael Comella (:mcomella) from comment #2)
> > As we discussed in today's meeting: we should break this into two fields
> > instead of one:
> > * session time in seconds (aggregate)
> > * number of sessions
> 
> Georg, do you have opinions on field names? I propose:
>  * sessionCount
>  * sessionDuration

Keeping with the shorter field names we tried to establish, how about:
* sessions
* durations
Flags: needinfo?(gfritzsche)
(In reply to Georg Fritzsche [:gfritzsche] from comment #17)
> > Georg, do you have opinions on field names? I propose:
> >  * sessionCount
> >  * sessionDuration
> 
> Keeping with the shorter field names we tried to establish, how about:
> * sessions
> * durations

To be fair though, i don't have a strong opinion about this.
If "saving bytes" is still a concern then we should use shorter names where reasonable though.

Updated

2 years ago
Attachment #8753581 - Flags: review?(ahunt) → review+

Comment 19

2 years ago
Comment on attachment 8753581 [details]
MozReview Request: Bug 1243595 - Add SessionMeasurements and tests. r=ahunt

https://reviewboard.mozilla.org/r/53360/#review50670

Comment 20

2 years ago
Comment on attachment 8754104 [details]
MozReview Request: Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt

https://reviewboard.mozilla.org/r/53722/#review50672
Attachment #8754104 - Flags: review?(ahunt) → review+

Updated

2 years ago
Attachment #8754105 - Flags: review?(ahunt) → review+

Comment 21

2 years ago
Comment on attachment 8754105 [details]
MozReview Request: Bug 1243595 - Add session measurement hooks for record and retrieval. r=ahunt

https://reviewboard.mozilla.org/r/53724/#review50674

Comment 23

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/557018e8059e
https://hg.mozilla.org/mozilla-central/rev/cfd333634aa2
https://hg.mozilla.org/mozilla-central/rev/65e3e5997825
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.