1243618 - Update Canvas Debugger for WebGL 2

Status: RESOLVED INVALID

(DevTools Graveyard :: Canvas Debugger, enhancement, P3)

Description

[Kelsey Gilbert [:jgilbert]]

WebGL 2 is on by default in Nightly, so we should ensure that it works with the debugger.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Can we have the links, to what's there now, in this bug?

Comment 2

[Kelsey Gilbert [:jgilbert]]

It seems to be:
devtools/server/actors/canvas.js

I think the code in devtools/client/canvasdebugger is for the UI.

Among other things, we need to:
* add webgl2 to CANVAS_CONTEXTS
* add to the list of DRAW_CALLS (we should include the instancing extension from WebGL 1 as well)
* Update to handle DRAW/READ_FRAMEBUFFER properly
* createBoundFramebuffer needs to respect context creation options (depth/stencil/alpha) (don't worry about dealing with antialias)

We need to find out:
* Does this rely on taking snapshots of framebuffers
* Does this work for self-mutating content (transform feedback and render-to-texture)

Hopefully vporof can help us out with information here.

Comment 3

[Victor Porof [:vporof][:vp]]

Indeed devtools/server/actors/canvas.js is the right place to make changes.

Framebuffer contents are retrieved for displaying a preview of whatever has been rendered in an animation frame (I assume that's what you're referring to with "taking snapshots"?). However, non-null framebuffer attachments are currently ignored and tracked in bug 1140731.

Comment 4

[reon90]

Any news about that? Shader and canvas debugging doesn't work for Webgl 2.

Comment 5

[BMO Automation]

The code behind DevTools:Canvas Debugger has gone away. Closing this bug as INVALID